Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Due to https://www.drupal.org/node/2549139, we need to fix some things.
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#7 | 3052510-7.patch | 10.76 KB | heddn |
Comments
Comment #2
heddnComment #3
heddnComment #4
mikelutzWhile I very much support this constructor change, It may be disruptive, as EntityGenerate is very often extended in custom code. It might be better to leave BC shim in for now and make this change in a 8.x-5.x branch
switching to EntityTypeManagerInterface is okay, because EntityManagerInterface extends EntityTypeManagerInterface so this is a widening of acceptable parameters and not a BC break, but EntityFieldManagerInterface should be at the end and be nullable to prevent a BC break
Comment #5
heddnA 5.x branch is (probably) ok. Does this reduce the chance of further (future) BC breaking changes even more?
Comment #6
NickDickinsonWildeI'd +1 on that being in a new 5.x branch; I do have around 8 plugins extending either EntityGenerate or EntityLookup in various migrations - some of which are regularly (cron) repeated.
Comment #7
heddnFix phpcs.
Comment #8
heddnWe'll do a new 5.x branch.
Comment #9
heddn