This patch allows field groups to be rendered on external entity types.
https://www.drupal.org/project/external_entities

CommentFileSizeAuthor
#2 3020916-enable_field_groups_on_external_entities-1.patch867 bytesKvermeir

Comments

Kvermeir created an issue. See original summary.

Kvermeir’s picture

Kvermeir commented
StatusFileSize
new 3020916-enable_field_groups_on_external_entities-1.patch867 bytes
Kvermeir’s picture

Kvermeir commented
Status: Reviewed & tested by the community » Needs review
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented 
+++ b/field_group.module
@@ -477,7 +481,7 @@ function field_group_build_entity_groups(array &$vars, $context = 'view') {
-    if ($context === 'eck_entity') {
+    if ($context === 'eck_entity' || $context === 'external_entity') {

this feels unsustainable, should we fire a hook instead?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: +australia-nz-friday-triage
hanno’s picture

hanno commented

+1 for an hook, we shouldn't have too much if statements based on other modules. was also mentioned in #3020924

hanno’s picture

hanno commented
Related issues: +#3020924: Configured fieldgroups not renderd
swentel’s picture

swentel commented

Would it work with that patch? I don't have strong feelings, so I can live with the current patch. Or if anyone else wants a hook, that's fine too.

rp7’s picture

rp7 commented

@swentel
JustFYI: been successfully using this patch together with #3020924: Configured fieldgroups not renderd on a rather large site for about 1.5 years now. So, to answer your question: yes, it does the trick.

swentel’s picture

swentel commented
Status: Needs review » Reviewed & tested by the community

Ok, I'll let zuuperman commit it then!

nils.destoop’s picture

nils.destoop commented
Status: Reviewed & tested by the community » Fixed

Ok, I pushed this to dev :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.