Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi,
First I want to mention thanks for this project.
Do you think it would be nice, that the code related to import/export content could abstracted as a separated module?
Best,
Comment | File | Size | Author |
---|---|---|---|
#9 | interdiff-2997011-6-9.txt | 2.44 KB | samuel.mortenson |
#9 | 2997011-9.patch | 105.71 KB | samuel.mortenson |
|
Comments
Comment #2
jmolivas CreditAttribution: jmolivas commentedComment #3
samuel.mortensonThanks @jmolivas! I think I'd prefer to abstract the HTML generation to another module, since the "new" thing Tome is solving is content entity export/import, not converting a website to static HTML. I offered to maintain the Static module in #2879232: Upgrade Static Generator module to Drupal 8, but am not sure what the status of that is.
The good news is that if all you want from Tome is the static content feature, you should be able to use it without worrying about the static HTML feature getting in your way. There will never be static HTML related code run unless you explicitly run
drush tome:static
, unlike the static content code which runs in response to entity CRUD events.Comment #4
samuel.mortensonChanging the issue title a bit - I think the best path forward is to split the static site generation and content import/export into sub-modules, which would still allow you to only require the sub-module without installing all of Tome (i.e.
composer require drupal/tome_export
). The main Tome module would ideally just be an info file installing both sub-modules.Part of that work will be re-working the StaticCache to only rely on content exports if they're available, many people have told me that they'd like to maintain an edit domain and only use Tome for exporting static HTML. Lots of work ahead, but I want to get this done!
Comment #5
samuel.mortensonDue to #2863986: Allow updating modules with new service dependencies updating to beta1 will have to require manual update steps.
Comment #6
samuel.mortensonHere we go...
Comment #7
samuel.mortensonAdded
drush tome:install
support here as well https://github.com/drupal-tome/tome_drush/commit/f0d644187998b6c637a64e1...Comment #8
samuel.mortensonTests pass, just want to sit on this overnight before committing.
Comment #9
samuel.mortensonUpgrade paths for Tome are going to be very difficult, I'm realizing.
Comment #11
samuel.mortensonDone! There should be no manual upgrade steps for alpha users, although I'll want to remove my workaround from #9 in stable.