SafeMarkup::checkPlain has been deprecated. Replace these calls with Html::escape.

CommentFileSizeAuthor
#6 0001-Issue-2995785-by-visabishek-fgm-Drupal-9-deprecation.patch15.19 KBfgm
#4 2995785-xmlrpc-replace_deprecated-4.patch7.11 KBfgm
#3 Capture d'écran 2018-08-29 16.33.01.png268.46 KBfgm
#2 replace_deprecated-2995785-2.patch784 bytesvisabhishek
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

visabhishek created an issue. See original summary.

visabhishek’s picture

visabhishek CreditAttribution: visabhishek as a volunteer and at Azri Solutions commented
Status: Active » Needs review
FileSize
replace_deprecated-2995785-2.patch784 bytes

Uploading patch

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm at OSInet commented
Status: Needs review » Needs work
FileSize
Capture d'écran 2018-08-29 16.33.01.png268.46 KB

Thanks. It's a good idea to fix deprecations, but there are several others, including one other case of checkPlain, usage of drupal_set_message(), and usage of the REQUEST_TIME constant, as shown in this screencopy. You can generate a similar report when working on deprecations in PhpStorm using Code / Run inspection by name / Deprecated (PHP / General)

Deprecations in XMLRPC

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm at OSInet commented
Status: Needs work » Needs review
FileSize
2995785-xmlrpc-replace_deprecated-4.patch7.11 KB

Patch completed, for you to review.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm at OSInet commented
Title: Replace deprecated usage of SafeMarkup::checkPlain() » Replace deprecated usage of SafeMarkup::checkPlain() and other deprecations
fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm at OSInet commented
FileSize
0001-Issue-2995785-by-visabishek-fgm-Drupal-9-deprecation.patch15.19 KB

Updated with more changes from #3117087: Drupal 9 Deprecated Code Report.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
CreditAttribution: wizonesolutions as a volunteer and at WizOne Solutions for FillPDF Service commented
Status: Needs review » Reviewed & tested by the community

I cloned the branch and applied the patch, then tested it against FillPDF 5.0.x (Drupal 9). Worked well.

Will also test against Drupal 8 now...OK, testing went well. Moving to RTBC.

  • fgm committed 4714816 on 8.x-1.x 
    Issue #2995785 by fgm, visabhishek, vsujeetkumar, ankithashetty,...

fgm credited ankithashetty.

fgm credited karishmaamin.

fgm credited pavnish.

fgm credited vsujeetkumar.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm at OSInet commented
Status: Reviewed & tested by the community » Fixed

Merged to 8.x-1.x HEAD, thanks all, including those who worked on the other duplicate issues.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.