Problem/Motivation

FieldEnhancers is a great idea and gives developers a lot of control. I can see a lot of cases where we could end up with a lot of custom enhancers.

Let's consider moving them under a \Plugin\jsonapi\Field\Enhancer namespace. This should make the implementation cleaner and be open for extension down the road (maybe other type of enhancers?).

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 interdiff-2874324-2-5.txt1.51 KBshadcn
#5 dx_consider_moving-2874324-5.patch2.83 KBshadcn
#2 dx_consider_moving-2874324-2.patch2.84 KBshadcn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

arshadcn created an issue. See original summary.

shadcn’s picture

shadcn CreditAttribution: shadcn at Chapter Three commented
Assigned: shadcn » Unassigned
Status: Active » Needs review
FileSize
dx_consider_moving-2874324-2.patch2.84 KB
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented

I like this! Only one minor change.

instead of 'Plugin/jsonapi/Field/Enhancer' let's use 'Plugin/jsonapi/FieldEnhancer'.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
Status: Needs review » Needs work
shadcn’s picture

shadcn CreditAttribution: shadcn at Chapter Three commented
Status: Needs work » Needs review
FileSize
dx_consider_moving-2874324-5.patch2.83 KB
interdiff-2874324-2-5.txt1.51 KB

This works too. New patch attached :)

  • e0ipso committed 31bef9c on 8.x-1.x authored by arshadcn 
    feat(DX): Move field enhancers under a Plugin\jsonapi\FieldEnhancer...
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.