Problem/Motivation

When using Views, you can add Custom Text Area in Header or Footer for instance. This Text Area can use the various text formatter you defined on your site. When using a text format allowing it, it should be able to use the WYSIWYG tool accordingly.

User interface changes

Let user use WYSIWYG tool when adding a text area in their view's header or footer.

CommentFileSizeAuthor
#35 no_balloon.png69.94 KBdom.
#35 expected_balloon.png71.71 KBdom.
#35 wysiwyg_views_text_area--2741187-34.patch592 bytesdom.
#31 diff_reroll_2741187_26-31.txt1.11 KBankithashetty
#31 2741187-31.patch566 bytesankithashetty
#27 2741187-applied_patch-26.gif3.02 MBabhijith s
#26 wysiwyg_views_text_area--2741187-26.patch770 bytesdom.
#8 wysiwyg_views_text_area--2741187-8.patch604 bytesdom.
#5 wysiwyg_views_text_area--2741187-2.patch630 bytesdom.
after.PNG9.66 KBdom.
before.PNG8.12 KBdom.

Issue fork drupal-2741187

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Dom. created an issue. See original summary.

dom.’s picture

dom. commented
Version: 8.2.x-dev » 8.1.x-dev
Status: Active » Needs review
Issue tags: +Usability, +d8ux, +D8UX usability

Adding patch.

Before patch:
Before applying patch

After patch:
After applying patch

dawehner’s picture

dawehner
Primary language German
commented

I remember back in d7 wysiwyg in the modal was just broken. Maybe (hopefully) this is no longer the case ...

dawehner’s picture

dawehner
Primary language German
commented

OH yeah, do you mind also uploading a patch :)

dom.’s picture

dom. commented
StatusFileSize
new wysiwyg_views_text_area--2741187-2.patch630 bytes

Oups ! Forgot to link the patch ! It's a very easy one !!

dawehner’s picture

dawehner
Primary language German
commented

We could remove the line completely ...

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Version: 8.1.x-dev » 8.2.x-dev

New features can only be added to 8.2.x

dom.’s picture

dom. commented
StatusFileSize
new wysiwyg_views_text_area--2741187-8.patch604 bytes

@dawehner: indeed, I just though it was more explicit since it is a feature change. But indeed, default value :)
@jibran: patch also applies cleanly on 8.2.x

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Cool! If things works, perfect!

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Reviewed & tested by the community » Needs review

Has anyone tried uploading an image through the editor dialog? This modal-in-modal was broken for a long time and was the reason for disabling the editor.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

jrockowitz’s picture

jrockowitz commented

There is still issues with modal-in-modal.

#2741877: Nested modals don't work: opening a modal from a modal closes the original

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Anonymous’s picture

Anonymous (not verified) commented
Related issues: +#2613208: [PP-1] Allow text formats to be used in global-text-fields in Views, +#2741877: Nested modals don't work: opening a modal from a modal closes the original

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

Duplicate of #2900594: CKEditor not available for Views "text" areas

gagarine’s picture

gagarine commented
Issue tags: -d8ux, -D8UX usability

Usability is preferred over UX, D7UX, D8UX etc. See https://www.drupal.org/issue-tags/topic

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

phily’s picture

phily
he/him
Primary language French
Location 🇪🇺🇫🇷 Paris, France
commented

Patch #8 works like a charm using Drupal 8.6.14, PHP 7.2.14
Thank you

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

We need a test for this, because currently this probably still breaks on #2741877: Nested modals don't work: opening a modal from a modal closes the original

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

dom.’s picture

dom. commented
Status: Needs work » Needs review
StatusFileSize
new wysiwyg_views_text_area--2741187-26.patch770 bytes

Just updating patch to 9.1.x / 9.2.x

abhijith s’s picture

abhijith s commented
StatusFileSize
new 2741187-applied_patch-26.gif3.02 MB

Applied patch #26 .The WYSIWYG editor is available in views text area fields after the patch.But its unable to add links and image in the text area.Please fix it. Adding the recording below
after

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

karimbou’s picture

karimbou commented

Patch isn't applying on Drupal 9.4.x aswell as 9.3.x

In Text.php we have now :

  /**
   * {@inheritdoc}
   */
  public function buildOptionsForm(&$form, FormStateInterface $form_state) {
    parent::buildOptionsForm($form, $form_state);

    $form['content'] = [
      '#title' => $this->t('Content'),
      '#type' => 'text_format',
      '#default_value' => $this->options['content']['value'],
      '#rows' => 6,
      '#format' => $this->options['content']['format'] ?? filter_default_format(),
      '#editor' => FALSE,
    ];
  }

Can we maybe just switch editor to TRUE ?

ankithashetty’s picture

ankithashetty
Location Karnataka, India
commented
StatusFileSize
new 2741187-31.patch566 bytes
new diff_reroll_2741187_26-31.txt1.11 KB

Yeah, patch in #26 failed to apply. Here is the re-rolled patch, thanks!

Status: Needs review » Needs work

The last submitted patch, 31: 2741187-31.patch, failed testing. View results

socialnicheguru’s picture

socialnicheguru commented

I am on the latest 9.2
Patch #26 adds ckeditor to global custom fields
But it strips links when they are added.
I wonder about the other patches.

Ckeditor works as expected in a normal text area

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new Screen Recording 2022-04-08 at 12.03.36.mov42.12 MB

I've tried out to use this with ckeditor5. Here is a little video: Here

Summary of the video: The 'modal' of the image alt text is not appearing. On top the toolbar sometimes hovers on top of everything else.

dom.’s picture

dom. commented
Version: 9.4.x-dev » 10.0.x-dev
StatusFileSize
new wysiwyg_views_text_area--2741187-34.patch592 bytes
new expected_balloon.png71.71 KB
new no_balloon.png69.94 KB

Trying the patch using D10 and CKEditor 5 : excitement of not having dialog in CKE5 made me believe that would work out of box solving our issue here.
This is not that far actually. But still some problem remains in some functionalities : namely one that has those "balloon"-like expected, for instance link or image plugin.

Expected :
expected balloon configuration
Observed:
No balloon

Therefore I guess at the moment, we can consider the initial "dialog" issue to transfer to a "balloon" issue.

Reproduction

- Apply the patch on drupal 10
- Configure a text format for CKE5
- Add a textarea in the header of one of the view
- Try to make a link or add an image within that textarea

tonytheferg’s picture

tonytheferg commented

Any way we could include the global text field in this patch also?

Version: 10.0.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

pfrilling made their first commit to this issue’s fork.

pfrilling opened merge request !8321

pfrilling’s picture

pfrilling
Location Minster, OH
commented

I created a merge request and confirmed that the CKEditor loads correctly and the image popup seems to be working properly.

I'm leaving this as needs work since it will require an automated test.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.