Use Drupal.formatPlural for when announcing module-filter results for screenreader users

Applied #3 ( 2715663-2.patch )on 8.2.x-dev and can confirm it is now saying "1 module is available in the modified list."

I updated the patch a little:

- Assigned getSession and getAssertSession() to variables so they don't have to be looked up each time
- Added asserts for the number of results.
- Added a condition for the wait() statements to improve tests performance.

Hi, I tried to apply this patch to 8.4.x, but it no longer applies. Going to attempt a re-roll.

I'm mentoring Em with this at DrupalCon Vienna.

Re-rolled the patch and tested with Voiceover.

One more thing; we don't update js files anymore directly.

Can you create a new patch with the changes applied to the es6.js file and then regenerate the js file? See issue 2815083: Drupal core now using ES6 for javascript development.

Updated patch:

• Removed $assertSession->statusCodeEquals(200); from test file.
• Applied system.modules.js changes to system.modules.es6.js and regenerated system.modules.js from that.

Updating system.module.es6.js so it applies to 8.9.x
Updating test file to replace JavascriptTestBase with WebDriverTestBase, also add missing $module and documentation

Updated with some coding standard fixes to ModuleFilterTest.php

Found via the Bug Smash Initiative random issue button.

This looks like a straightforward fix and should be ready to go in, just needs a reroll.

Rerolled the patch in #27, thanks!

Thanks! There are some spelling and JS style issues picked up by the bot, see https://www.drupal.org/pift-ci-job/2207441 for details.

Fixed custom command failure errors in #32, thanks!

Thanks again - one more trailing comma to add then this is good to go, I think.

This will fix the custom commands failure & added an interdiff.

Hope this updated patch will resolve test failures. Added an interdiff as well.

Changing public static $modules to protected static $modules as per this change record - $modules property on BrowserTestBase and KernelTestBase is protected - https://www.drupal.org/node/2833984

Tried to fix build fail in #38. Attached interdiff file

This issue is being reviewed by the kind folks in Slack, #need-reveiw-queue. We are working to keep the size of Needs Review queue [2700+ issues] to around 200, following Review a patch or merge require as a guide.

D10 version needed
At this time we would need a D10.1.x patch or MR for this issue.

Rerolled.

Test this out on D10.1

When 1 option confirmed it's using singular module language.
Test fails without the fix. Passes with it.

Good to mark this.

1. This issue is looking good - just a few minor nits

2. +++ b/core/modules/system/tests/src/FunctionalJavascript/ModuleFilterTest.php
   @@ -0,0 +1,96 @@
   +    self::assertNotEquals(count($module_rows), count($visible_rows));
   

   I think this is more meaningful if self::assertGreaterThan(count($visible_rows), count($module_rows));

3. +++ b/core/modules/system/tests/src/FunctionalJavascript/ModuleFilterTest.php
   @@ -0,0 +1,96 @@
   +    // Test Drupal.announce() message when multiple matches are expected.
   +    $expected_message = count($visible_rows) . ' modules are available in the modified list.';
   

   I think we should do $this->assertGreaterThan(1, count($visible_rows)); just so this test fails in the right place if this is 0.

4. +++ b/core/modules/system/tests/src/FunctionalJavascript/ModuleFilterTest.php
   @@ -0,0 +1,96 @@
   +  protected function filterVisibleElements($elements) {
   

   filterVisibleElements(array $elements): array {

Tried to address comment #47, please review.

Addressed PHPCS issue of patch #48.

Confirmed points #47 were addressed.

Retested test file without the fix and failed

PHPUnit 9.5.26 by Sebastian Bergmann and contributors.

Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

Testing /var/www/html/web/core/modules/system/tests/src/FunctionalJavascript

Behat\Mink\Exception\ElementTextException : The text "1 module is available in the modified list." was not found in the text of the element matching css "#drupal-live-announce".

With the fix it's all green as we can see.

Random ckeditor error

1. +++ b/core/modules/system/tests/src/FunctionalJavascript/ModuleFilterTest.php
   @@ -53,11 +53,8 @@ public function testModuleFilter() {
   -    // Test Drupal.announce() message when multiple matches are expected.
   -    $expected_message = count($visible_rows) . ' modules are available in the modified list.';
   -    $assertSession->elementTextContains('css', '#drupal-live-announce', $expected_message);
   

   This should not have been removed.

2. +++ b/core/modules/system/tests/src/FunctionalJavascript/ModuleFilterTest.php
   @@ -53,11 +53,8 @@ public function testModuleFilter() {
   +    self::assertGreaterThan(count($visible_rows), count($module_rows));
   +    $this->assertGreaterThan(1,  count($visible_rows));
   

   Mixing $this->assert and self::assert is odd... let's change $this-> to self:: to be consistent with everything else in this file.

Made changes as per comment #53, please review.

appears the changes from 53 have been made.

Committed 78a7b47 and pushed to 10.1.x. Thanks!

Not backporting this because of the string change.