Add a view builder for contact_form

Why not use a block for that?

1. +++ b/src/ContactFormViewBuilder.php
   @@ -0,0 +1,118 @@
   +
   +class ContactFormViewBuilder extends EntityViewBuilder {
   

   needs doc block

2. +++ b/src/ContactFormViewBuilder.php
   @@ -0,0 +1,118 @@
   +  protected function entityFormBuilder() {
   ...
   +  protected function getRenderer() {
   ...
   +  protected function config($name) {
   ...
   +  private function container() {
   

   Why? this is a EntityViewBuilder so createInstance() could pass deps

Makes a lot of sense

Makes a lot of sense

Since you're overriding view completely and not calling parent, you need to do the same for viewMultiple.
And at that point, you don't need the rest of the parent class, and it's all useless.

Looks good, just needs a test - thanks!

I'm getting this error with the patch from #8:

The website encountered an unexpected error. Please try again later.
Recoverable fatal error: Argument 1 passed to Drupal\contact_storage\ContactFormViewBuilder::__construct() must be an instance of Drupal\Core\Entity\EntityFormBuilderInterface, instance of Drupal\Core\Config\Entity\ConfigEntityType given, called in core/lib/Drupal/Core/Entity/EntityTypeManager.php on line 254 and defined in Drupal\contact_storage\ContactFormViewBuilder->__construct() (line 68 of modules/contrib/contact_storage/src/ContactFormViewBuilder.php). 

The patch from #2 works perfectly.

Needs tests indeed :)

Patch in #12 worked perfectly for me, but I'll leave the status since we still need tests (#9).

#12 works for me as well
Tested with entity_embed and contact form easily embedded via wysiwyg button.
Cool

I can confirm that #12 works like a charm.

Thank you guys.

We still need tests here

Added webtest for checking whether the contact form is showing. Can we write kerneltest case(will take less time to run) for checking view builder.

Committed with the attached cleanup

patch has not yet pushed to repo

oh, didn't merge - but was pushed to a branch - checking the release now

release is fine

So how do i use this?
Can't find anywhere where to add for example as a block.

You can also install the drupal 8 version of Ctools. It provides a handy entity_view block which you can use everywhere (blocks, panels, pagemanager etc).

This functionality should be added to the project page, love it!

Filed separate issue for that #2657880: Add hook_help and update project page

I'm tryinng this with entity embed and it does not give me the option to view the entire contact form, only id or link