Problem/Motivation

This is a followup to #2056089: UI problems on the Modules/Extend page
When we are installing/uninstalling modules, messages are not the same on Extend page. Check screenshots attached. The task here is to make them the same.

The original comment from the IS in that issue
4. Confusing message when you enable a module: If I check a box to enable a module and save, the message I get is "The configuration options have been saved. " ... um? Shouldn't it tell me my module(s) were installed? That is all you can do on this screen, so it doesn't even have to figure out what you submitted. [originally this was (d).] The messages should be consistent with the language used for disabling a module,
"The selected modules have been uninstalled." - so let's make it "The selected modules have been installed".

Suggested replacement message: The selected modules have been installed.

Proposed resolution

Change the install message to be 'The selected modules have been installed'

Remaining tasks

Write a Patch
Write a test
Review
Commit

User interface changes

Yes,

API changes

N/A

Issue fork drupal-2532652

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

manjit.singh’s picture

Component: other » system.module

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

quietone’s picture

Title: messages are not the same on Extend page » Make the install and uninstall message the same
Version: 8.9.x-dev » 9.1.x-dev
Component: system.module » extension system
Issue summary: View changes
Issue tags: +Bug Smash Initiative

This is still true on 8.6.19.

Seems like this should be in the extension system, so changing component. Updated the IS and made the title state what is to be done here.

quietone’s picture

Status: Active » Needs review
StatusFileSize
new8.64 KB

Started a patch.

Status: Needs review » Needs work

The last submitted patch, 11: 2532652-11.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

quietone’s picture

Status: Needs work » Needs review
StatusFileSize
new4.62 KB
new13.16 KB

Just fixing the tests.

Status: Needs review » Needs work

The last submitted patch, 13: 2532652-13.patch, failed testing. View results

quietone’s picture

Status: Needs work » Needs review
StatusFileSize
new608 bytes
new13.94 KB

Missed one.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

manojithape’s picture

Getting error at the time of applying patch # 15 on the drupal version 9.2.0-dev.

manojithape’s picture

StatusFileSize
new55.97 KB

Getting error at the time of applying patch # 15 on the drupal version 9.2.0-dev.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

bhumikavarshney’s picture

Status: Needs review » Needs work
StatusFileSize
new171.41 KB

Am also getting error while applying #15 patch.
Adding SS for reference.

neslee canil pinto’s picture

Status: Needs work » Needs review
StatusFileSize
new13.09 KB

Rerolled patch to latest version

Status: Needs review » Needs work

The last submitted patch, 21: 2532652-21.patch, failed testing. View results

spokje’s picture

Issue summary: View changes
Status: Needs work » Needs review
spokje’s picture

Status: Needs review » Needs work
spokje’s picture

Assigned: Unassigned » spokje
spokje’s picture

Started MR with 2532652-21.patch as a base.

spokje’s picture

Assigned: spokje » Unassigned
Status: Needs work » Needs review
quietone’s picture

There is a later issue which is a duplicate of this. #2891294: [Meta] Use Install/Uninstall consistently for turning modules/themes on/off (not Enable). That one is a child of a Meta #2888657: [meta] Less confusing and more consistent wording needed in module/theme add/install/update to improve the use of install/uninstall. The other issue has a much more detailed Issue Summary and comments that relate the issue to the other children and provide a good overview of the work.

I think the best thing to do is to mark this as a duplicate, post the patch over there and add credit.