Problem/Motivation
This is a followup to #2056089: UI problems on the Modules/Extend page
When we are installing/uninstalling modules, messages are not the same on Extend page. Check screenshots attached. The task here is to make them the same.
The original comment from the IS in that issue
4. Confusing message when you enable a module: If I check a box to enable a module and save, the message I get is "The configuration options have been saved. " ... um? Shouldn't it tell me my module(s) were installed? That is all you can do on this screen, so it doesn't even have to figure out what you submitted. [originally this was (d).] The messages should be consistent with the language used for disabling a module,
"The selected modules have been uninstalled." - so let's make it "The selected modules have been installed".
Suggested replacement message: The selected modules have been installed.
Proposed resolution
Change the install message to be 'The selected modules have been installed'
Remaining tasks
Write a Patch
Write a test
Review
Commit
User interface changes
Yes,
API changes
N/A
| Comment | File | Size | Author |
|---|---|---|---|
| Uninstall-drupal8.png | 268.22 KB | manjit.singh | |
| Extend-drupal8.png | 333.58 KB | manjit.singh |
Issue fork drupal-2532652
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 2532652-make-the-install
changes, plain diff MR !651
Comments
Comment #1
manjit.singhComment #10
quietone commentedThis is still true on 8.6.19.
Seems like this should be in the extension system, so changing component. Updated the IS and made the title state what is to be done here.
Comment #11
quietone commentedStarted a patch.
Comment #13
quietone commentedJust fixing the tests.
Comment #15
quietone commentedMissed one.
Comment #17
manojithape commentedGetting error at the time of applying patch # 15 on the drupal version 9.2.0-dev.
Comment #18
manojithape commentedGetting error at the time of applying patch # 15 on the drupal version 9.2.0-dev.
Comment #20
bhumikavarshney commentedAm also getting error while applying #15 patch.
Adding SS for reference.
Comment #21
neslee canil pintoRerolled patch to latest version
Comment #23
spokjeComment #24
spokjeComment #25
spokjeComment #26
spokjeStarted MR with
2532652-21.patchas a base.Comment #28
spokjeComment #29
quietone commentedThere is a later issue which is a duplicate of this. #2891294: [Meta] Use Install/Uninstall consistently for turning modules/themes on/off (not Enable). That one is a child of a Meta #2888657: [meta] Less confusing and more consistent wording needed in module/theme add/install/update to improve the use of install/uninstall. The other issue has a much more detailed Issue Summary and comments that relate the issue to the other children and provide a good overview of the work.
I think the best thing to do is to mark this as a duplicate, post the patch over there and add credit.