Why is a warning always displayed on Date API install even if the timezone, first day of week, and date format settings are correctly set? (see line 75 of http://www.drupalcontrib.org/api/drupal/contributions!date!date_api!date...). Wouldn't it be better to do variable_get checks like http://www.drupalcontrib.org/api/drupal/contributions!date!date_api!date... ?

CommentFileSizeAuthor
#7 date-n2503301-7.patch1.95 KBDamienMcKenna
#4 date_api-warning_message_check-2503301-3.patch1.44 KBemmonsaz
#1 date_api-warning_message_check-2503301-1.patch1.4 KBemmonsaz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

emmonsaz’s picture

emmonsaz CreditAttribution: emmonsaz as a volunteer commented
FileSize
date_api-warning_message_check-2503301-1.patch1.4 KB

Suggested patch...

emmonsaz’s picture

emmonsaz CreditAttribution: emmonsaz as a volunteer commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: date_api-warning_message_check-2503301-1.patch, failed testing.

emmonsaz’s picture

emmonsaz CreditAttribution: emmonsaz as a volunteer commented
FileSize
date_api-warning_message_check-2503301-3.patch1.44 KB

re-rolled...

emmonsaz’s picture

emmonsaz CreditAttribution: emmonsaz as a volunteer commented
Status: Needs work » Needs review
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

Seems reasonable.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #3301877: Plan for Date 7.x-2.14
FileSize
date-n2503301-7.patch1.95 KB

Rerolled, with some adjustments to the wording.

  • DamienMcKenna committed d5dbf731 on 7.x-2.x 
    Issue #2503301 by emmonsaz, DamienMcKenna: Conditional warning on...

  • DamienMcKenna committed 0093a88f on 7.x-3.x 
    Issue #2503301 by emmonsaz, DamienMcKenna: Conditional warning on...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Committed. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.