comment at top of comment_hacks.css references removed function

File is: core/tests/Drupal/Tests/Core/Asset/css_test_files/comment_hacks.css

Fixing issue title.

To do more alot in Drupal8. I have to learn alot.

No, you just need to replace drupal_load_stylesheet_content with proper reference to curent function

I think CssOptimizer::loadFile will replace the drupal_load_stylesheet_content() method.

The function is removed in #352951: Make JS & CSS Preprocessing Pluggable
But test still there, so please check the usage of that file

+++ b/core/tests/Drupal/Tests/Core/Asset/css_test_files/comment_hacks.css
@@ -1,6 +1,6 @@
+* of function <code>CssOptimizer::loadFile

.

Please use full namespaced path to class

Added namespace for class.

+++ b/core/tests/Drupal/Tests/Core/Asset/css_test_files/comment_hacks.css
@@ -1,6 +1,6 @@
+* of function <code>Drupal\Core\Asset\CssOptimizer::loadFile

.

s/loadFile/loadFile() this is a function so please add () at the end

Fixed this minor issue

Great!

So... It looks like this hacks CSS file is used in Core only in \Drupal\system\Tests\Asset\CssOptimizerUnitTest.

The method that this test is testing appears to be \Drupal\Core\Asset\CssOptimizer::optimize().

So, I think maybe the @file comment at the top of this file should maybe say something like "This file is used in testing CssOptimizer::optimize() in CssOptimizerUnitTest" (cleaned up and with the full namespaces).

Also, there are standards issues with the current patch:
- Namespaces in docs need to start with \
- This file doesn't have a @file block. The comment here should be made into a @file block.
- See https://www.drupal.org/node/1354 for standards on how to write a @file block, including that the first line should be 80 characters.

Please review.

the first line should be 80 characters

as declared, but

+++ b/core/tests/Drupal/Tests/Core/Asset/css_test_files/comment_hacks.css
@@ -1,8 +1,12 @@
+ * @file
+ * A sample css file, designed to test the effectiveness and stability
+ * of function <code>\Drupal\Core\Asset\CssOptimizer::loadFile()

.

should be 1 line!

+/**
+ * @file
+ * A sample css file, designed to test the effectiveness and stability of
+ * function <code>\Drupal\Core\Asset\CssOptimizer::loadFile()

.
+ *
+ * This file is used in testing CssOptimizer::optimize() in
+ * CssOptimizerUnitTest.
+ */

Ok. The first line needs to be one sentence summarizing what the file is. How about:
CSS file with special comments for testing.

Then you can put in the other documentation in additional paragraphs. And still, EVERY mention of a class in documentation is supposed to include the FULL NAMESPACE. And don't use CODE tags in docs.

@jhodgdon thank you for your review.

Closer!

+ * @file
+ * CSS file with special comments for testing

This line needs to end in .

And then I think the two separate paragraphs below can be combined? Is the file really used for testing all of those things?

Done as per #21.

Is the file really used for testing all of those things?

Yes, this file is being used for testing.

See comment #13 above. I am aware the file is used in testing. I'm not sure it is used to test all the things the @file block says it is used for; specifically, \Drupal\Core\Asset\CssOptimizer::loadFile(). All I see it being used for is testing the optimize() method.

Other than that question, the patch looks good. Thanks!

rerolling patch in accordance with #13.

Thanks! Sorry for the delay in reviewing. This looks fine to me.

Me too. Committed bf39af8 and pushed to 8.0.x. Thanks!