Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
BlockLanguageTest
calls $this->drupalGet('node')
without installing the node module etc.
Proposed resolution
Make BlockLanguageTest
by ensuring that it calls existing pages.
Remaining tasks
User interface changes
API changes
Beta phase evaluation
Issue category | Bug because the test coverage is wrong. |
---|---|
Issue priority | Normal because the issue was only found in a single test. |
Unfrozen changes | Unfrozen because it only changes tests. (Which? Specify.) |
Comment | File | Size | Author |
---|---|---|---|
#23 | 2430133-21.patch | 3.63 KB | quietone |
| |||
#21 | 2430133-21.patch | 3.63 KB | JeroenT |
#20 | 2430133-20.patch | 3.65 KB | JeroenT |
Comments
Comment #1
znerol CreditAttribution: znerol commentedPatch inserts some asserts demonstrating the problem.
Comment #2
znerol CreditAttribution: znerol commentedComment #4
Anonymous (not verified) CreditAttribution: Anonymous commentedRerolled the patch from #1. Only 3 out of 6 occurrences failed locally. Let's see what testbot thinks of this.
Comment #5
Anonymous (not verified) CreditAttribution: Anonymous commentedAdded beta eval.
Comment #6
mgiffordRe-uploading patch for the bots.
Comment #18
JeroenTComment #20
JeroenTComment #21
JeroenTComment #23
quietone CreditAttribution: quietone at PreviousNext commentedI reviewed the patch in #21. The changes look correct to me. It still applies to D10 and the modified test passes locally.
Uploading again to move to D10. I plan to RTBC after tests run.
Comment #24
quietone CreditAttribution: quietone at PreviousNext commentedAs expected tests are passing.
Comment #26
JeroenTUnrelated test failures.
Comment #27
alexpottCommitted and pushed b8a325c351 to 10.0.x and 080690741d to 9.5.x and 7d583738ac to 9.4.x. Thanks!
As #23 was only to prove the tests pass on D10 and is exactly the same as #21 I've removed credit for @quietone.
Backported to 9.4.x as a test-only change.