CommentFileSizeAuthor
#16 2220275-16.patch13.09 KBjaperry
#14 2220275-14.captcha.Allow-for-skipping-captcha-based-on-IP-Address-or-IP-Range.patch12.04 KBoldspot
#11 2220275-11-D8-captcha_added_whitelisted_ips_settings.patch12.17 KBalunyov
#9 2220275-9-D8-captcha_added_whitelisted_ips_settings.patch12.16 KBalunyov
#9 2220275-9-D8-captcha_added_whitelisted_ips_settings.png46.19 KBalunyov
#8 CAPTCHA-Allow-for-skipping-captcha-based-on-IP-7.x.1.d.patch13.51 KBthisisnotrealpeople
#4 CAPTCHA-Allow-for-skipping-captcha-based-on-IP-2220275.5.patch14.73 KBdarrellduane
#1 CAPTCHA-Allow-for-skipping-captcha-based-on-IP-2220275.1.patch13.78 KBdarrellduane

Comments

darrellduane’s picture

darrellduane commented
Status: Active » Needs review
StatusFileSize
new CAPTCHA-Allow-for-skipping-captcha-based-on-IP-2220275.1.patch13.78 KB

Here is a patch. Thanks to the code from the ip_range module I was able to get this retrofitted rapidly.

Status: Needs review » Needs work

The last submitted patch, 1: CAPTCHA-Allow-for-skipping-captcha-based-on-IP-2220275.1.patch, failed testing.

darrellduane’s picture

darrellduane commented

Does testing run update.php ? the error I'm seeing here in the test came from the lack of the new database table being present, not sure why the changes I made to the captcha.install file didn't get executed.

darrellduane’s picture

darrellduane commented
Status: Needs work » Needs review
StatusFileSize
new CAPTCHA-Allow-for-skipping-captcha-based-on-IP-2220275.5.patch14.73 KB

I found the problem, I needed to add some more information to my .install file in order to make it create the database table.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Needs work

#4 there are a lot of trailing whitespace errors in the patch.
Please, use drupal coding style to fix them all
Also - all the comments should be closed with a full stops.

thisisnotrealpeople’s picture

thisisnotrealpeople commented

This is a feature that I'd love to see included in the production release.

Are there any plans to incorporate it?

Need any assistance?

elachlan’s picture

elachlan commented
Version: 7.x-1.x-dev » 8.x-1.x-dev

Do a patch up and we will see about including it.

All changes are done to 8.x first and back ported to 7.x.

thisisnotrealpeople’s picture

thisisnotrealpeople commented
StatusFileSize
new CAPTCHA-Allow-for-skipping-captcha-based-on-IP-7.x.1.d.patch13.51 KB

I am attaching an updated patch that works with 7.x-1.x-dev / 7.x.1.4 but unfortunately I just don't know how to implement the same feature/patch to Drupal 8. I have been trying to figure it out, but it seems to be really different from 7. If I can find more time to investigate and play around I will, but if someone else beats me to it, I would love to know exactly what is involved in transposing this patch for 7 forward to 8!!

alunyov’s picture

alunyov commented
Assigned: darrellduane » Unassigned
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 2220275-9-D8-captcha_added_whitelisted_ips_settings.png46.19 KB
new 2220275-9-D8-captcha_added_whitelisted_ips_settings.patch12.16 KB

Hi Guys,
I have added patch for creating whitelisted IPs for which should not be shown CAPTCHA in the form:
Whitelisted IPs settings
Comparing to old patches it allows to have multiple ips addresses and ip ranges (check screenshot above) without having custom table. There is no reason to have new table `captcha_ip_ranges`, because if user doesn't use this setting the table will be created anyway and it will stay empty in DB. And it works with dev version of the module for now.
Please review the patch.

Status: Needs review » Needs work

The last submitted patch, 9: 2220275-9-D8-captcha_added_whitelisted_ips_settings.patch, failed testing.

alunyov’s picture

alunyov commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 2220275-11-D8-captcha_added_whitelisted_ips_settings.patch12.17 KB

Updated patch. Should pass tests now

Status: Needs review » Needs work

The last submitted patch, 11: 2220275-11-D8-captcha_added_whitelisted_ips_settings.patch, failed testing. View results

couturier’s picture

couturier commented
Related issues: +#2982140: Captcha is unusable with current beta and DEV state

Is anyone able to join the push to get a stable 8.x version of this module released so we can incorporate this and other patches?

oldspot’s picture

oldspot commented
Status: Needs work » Needs review
StatusFileSize
new 2220275-14.captcha.Allow-for-skipping-captcha-based-on-IP-Address-or-IP-Range.patch12.04 KB

I've checked the latest dev code and still can't see any IP whitelisting functionality so I've ported this patch to the latest version of the module.

gopisathya’s picture

gopisathya commented

Patch #14 fails with 8.x-1.3 version. Works with 8.x-1.2

japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 2220275-16.patch13.09 KB

Re-rolled against 1.3 Sorry I missed this in that release! I've RTBC'd it, so we can commit it before 1.4

  • japerry committed 1a3adbd on 8.x-1.x 
    Issue #2220275 by alunyov, DarrellDuane, thisisnotrealpeople, oldspot:...
japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.