Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Does testing run update.php ? the error I'm seeing here in the test came from the lack of the new database table being present, not sure why the changes I made to the captcha.install file didn't get executed.
#4 there are a lot of trailing whitespace errors in the patch.
Please, use drupal coding style to fix them all
Also - all the comments should be closed with a full stops.
I am attaching an updated patch that works with 7.x-1.x-dev / 7.x.1.4 but unfortunately I just don't know how to implement the same feature/patch to Drupal 8. I have been trying to figure it out, but it seems to be really different from 7. If I can find more time to investigate and play around I will, but if someone else beats me to it, I would love to know exactly what is involved in transposing this patch for 7 forward to 8!!
Hi Guys,
I have added patch for creating whitelisted IPs for which should not be shown CAPTCHA in the form:
Comparing to old patches it allows to have multiple ips addresses and ip ranges (check screenshot above) without having custom table. There is no reason to have new table `captcha_ip_ranges`, because if user doesn't use this setting the table will be created anyway and it will stay empty in DB. And it works with dev version of the module for now.
Please review the patch.
Comments
Comment #1
DarrellDuane CreditAttribution: DarrellDuane commentedHere is a patch. Thanks to the code from the ip_range module I was able to get this retrofitted rapidly.
Comment #3
DarrellDuane CreditAttribution: DarrellDuane commentedDoes testing run update.php ? the error I'm seeing here in the test came from the lack of the new database table being present, not sure why the changes I made to the captcha.install file didn't get executed.
Comment #4
DarrellDuane CreditAttribution: DarrellDuane commentedI found the problem, I needed to add some more information to my .install file in order to make it create the database table.
Comment #5
podarok#4 there are a lot of trailing whitespace errors in the patch.
Please, use drupal coding style to fix them all
Also - all the comments should be closed with a full stops.
Comment #6
thisisnotrealpeople CreditAttribution: thisisnotrealpeople commentedThis is a feature that I'd love to see included in the production release.
Are there any plans to incorporate it?
Need any assistance?
Comment #7
elachlan CreditAttribution: elachlan commentedDo a patch up and we will see about including it.
All changes are done to 8.x first and back ported to 7.x.
Comment #8
thisisnotrealpeople CreditAttribution: thisisnotrealpeople as a volunteer commentedI am attaching an updated patch that works with 7.x-1.x-dev / 7.x.1.4 but unfortunately I just don't know how to implement the same feature/patch to Drupal 8. I have been trying to figure it out, but it seems to be really different from 7. If I can find more time to investigate and play around I will, but if someone else beats me to it, I would love to know exactly what is involved in transposing this patch for 7 forward to 8!!
Comment #9
alunyov CreditAttribution: alunyov at FFW commentedHi Guys,
I have added patch for creating whitelisted IPs for which should not be shown CAPTCHA in the form:
Comparing to old patches it allows to have multiple ips addresses and ip ranges (check screenshot above) without having custom table. There is no reason to have new table `captcha_ip_ranges`, because if user doesn't use this setting the table will be created anyway and it will stay empty in DB. And it works with dev version of the module for now.
Please review the patch.
Comment #11
alunyov CreditAttribution: alunyov at FFW commentedUpdated patch. Should pass tests now
Comment #13
couturier CreditAttribution: couturier as a volunteer commentedIs anyone able to join the push to get a stable 8.x version of this module released so we can incorporate this and other patches?
Comment #14
oldspot CreditAttribution: oldspot at Zoocha commentedI've checked the latest dev code and still can't see any IP whitelisting functionality so I've ported this patch to the latest version of the module.
Comment #15
gopisathya CreditAttribution: gopisathya commentedPatch #14 fails with 8.x-1.3 version. Works with 8.x-1.2
Comment #16
japerryRe-rolled against 1.3 Sorry I missed this in that release! I've RTBC'd it, so we can commit it before 1.4
Comment #18
japerry