This patch to smartqueue taxonomy allows users to choose to let nodes be added to any of their term's ancestor nodequeues.

It is based on the patch adding 'use_parents'.

Use case:
1. Taxonomy as follows:

- Plants
  - Crops
    - Oats
    - Barley

2. Crops page has a featured content view, which uses nodequeue.
3. People would like to add Oats related articles to the Crops featured content nodequeue.

The patch provides the changes to the admin forms and a hook_update_n to modify the table.

Cheers,
Sam.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

samhassell’s picture

Issue summary: View changes

added pre tags

samhassell’s picture

It would be nice to get this into 2.x too, that way I can use it in prod :P

What's the diff between 3.x and 2.x?

samhassell’s picture

here's one for 2.x.

Status: Needs review » Needs work

The last submitted patch, smartqueue--use-parents-all-2.x.patch, failed testing.

samhassell’s picture

Status: Needs work » Needs review

2.x one failed against 3.x I'm guessing.

killua99’s picture

Version: 7.x-3.x-dev » 7.x-2.x-dev
killua99’s picture

Status: Needs review » Needs work

The last submitted patch, smartqueue--use-parents-all-2.x.patch, failed testing.

Anonymous’s picture

Issue summary: View changes

switched pre to code tags le sigh

thursday_bw’s picture

Issue summary: View changes
FileSize
4.29 KB

Here is a new version of the smartqueue--use-parents-all patch.
In time the previous patch has become outdated and doesn't apply cleanly.
It does now.
Also this patch fixes a bug introduced by the previous patch, where smartqueues were being created twice in the database and causing duplicates.

thursday_bw’s picture

Status: Needs work » Needs review
fizk’s picture

Status: Needs review » Active
fizk’s picture

Status: Active » Needs review

Hoping this starts the automated tests.

Status: Needs review » Needs work

The last submitted patch, 12: smartqueue--use-parents-all-12.patch, failed testing.

The last submitted patch, 12: smartqueue--use-parents-all-12.patch, failed testing.

The last submitted patch, 12: smartqueue--use-parents-all-12.patch, failed testing.

The last submitted patch, 12: smartqueue--use-parents-all-12.patch, failed testing.

fizk’s picture

Status: Needs work » Needs review
fizk’s picture

The db_query("SELECT qid, use_parents, use_parents_all FROM {smartqueue} WHERE qid IN (:qids)", array(':qids' => $qids)); was causing the entire site to crash immediately, not giving the admin a chance to update the database schema via the UI.

This patch changes the query to db_query("SELECT * FROM {smartqueue} WHERE qid IN (:qids)", array(':qids' => $qids));

Status: Needs review » Needs work

The last submitted patch, 19: smartqueue--use-parents-all-19.patch, failed testing.

The last submitted patch, 19: smartqueue--use-parents-all-19.patch, failed testing.

  • fizk committed 9dbe16e on 7.x-2.x
    Issue #1869132 by fizk, samhassell, thursday_bw: Use all term ancestors...

The last submitted patch, 19: smartqueue--use-parents-all-19.patch, failed testing.

fizk’s picture

Committed, thanks.

The last submitted patch, 19: smartqueue--use-parents-all-19.patch, failed testing.

  • fizk committed ef86dbc on 7.x-2.x
    Fix previous commit from Issue #1869132.
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.