Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
According to the RC3 announcement:
And files[] is no longer required in .info files for each file! Only if the file in question registers a class or interface. $cruft--;
So I cleaned the info files a bit, I'm aware I don't know anyything baout ctools so this can be wrong.
This NEEDS to be rechecked cause I dont want to brake ctools:)
I also ADDED some files with classes in it. I putted a ; before them.
Comment | File | Size | Author |
---|---|---|---|
#7 | remove_cruft_from_info_ctoolsv4.patch | 9.14 KB | aspilicious |
#4 | remove_cruft_from_info_ctoolsv3.patch | 9.08 KB | aspilicious |
#3 | remove_cruft_from_info_ctoolsv2.patch | 9.08 KB | aspilicious |
remove_cruft_from_info_ctools.patch | 9.36 KB | aspilicious |
Comments
Comment #1
merlinofchaos CreditAttribution: merlinofchaos commentedAny class that is part of a plugin (easily spotted by being a file with the 'class.php' extension) does NOT need to be registered.
Also, scripts in the info file will always be added, right? If that's the case, I believe we do not want to add any of these scripts.
Comment #2
aspilicious CreditAttribution: aspilicious commented1) OK :) nice to know
2) Yes they will always be included, I'll delete them
Comment #3
aspilicious CreditAttribution: aspilicious commentedSecond try.
I have some problems getting used to git so hopefully this went fine.
Comment #4
aspilicious CreditAttribution: aspilicious commentedSomething went wrong...
Another try...
EDIT
----
This one is ok I think
What should we do with test files?
EXTRA INFO
------------
Dreditor: 10 files changed, 4 insertions, 136 deletions.
Comment #5
aspilicious CreditAttribution: aspilicious commentedI also think this patch will solve the error I have in my logs:
Invalid plugin module/type combination requested: module stylizer and type style_bases
Comment #6
merlinofchaos CreditAttribution: merlinofchaos commentedNo, that problem happens because stylizer.theme.inc needs to be in stylizer.module not ctools.module or at least have an if() to make it only run if stylizer.module is enabled.
Comment #7
aspilicious CreditAttribution: aspilicious commentedTest files also contain a class so they have to be included.
Comment #8
merlinofchaos CreditAttribution: merlinofchaos commentedLooks ok now, I think.