Remove taxonomy_term_load_multiple() in favour of \Drupal\taxonomy\Entity\Term::loadMultiple().

WDG (Ukraine,Kharkov) want to implement this on CodeSprintUA.

Patch no longer applies. But also I did the following grep, and the only result is the deprecated function definition.

grep -rsn "taxonomy_term_load_multiple(" .
./core/modules/taxonomy/taxonomy.module:682:function taxonomy_term_load_multiple(array $tids = NULL) {

So I believe this ticket is now obsolete.

Note: the patches need to be modified because they include changes that were addressed as part of #2022509: Deprecate taxonomy_vocabulary_load_multiple() and taxonomy_term_load_multiple() in favour of entity_load_multiple(). The related issue addressed removing references to the wrapper function but left the wrapper function and tests intact in the taxonomy module code.

I asked myself "Should we complete removing the deprecated wrapper function (taxonomy_term_load_multiple) found here: core/modules/taxonomy/taxonomy.module [lines 682 to 684]?

I believe that yes, we should remove the function and it's related tests (LoadMultipleTest).

I'm working on the patch.

Created patch which removed the test file and edited taxonomy.module to remove unwanted wrapper function.

@Andypost given that taxonomy_term_load_multiple_by_name() is more then a wrapper function would it make sense to separate this out into a second issue so that we can complete removing taxonomy_term_load_multiple_by_name()?

Presently the function is found in the taxonomy.module, TermLanguageTest.php, VocabularyPermissionsTest.php, and TermTest.php which tests more then just taxonomy_term_load_multiple_by_name().

In the event all usage of taxonomy_term_load_multiple_by_name() should simply be removed from the 4 files mentioned above, I'd be happy to re-create the patch.

I've split taxonomy_term_load_multiple_by_name() out into #2197767: Remove uses of Deprecate taxonomy_term_load_multiple_by_name() in favour of entity_load_multiple_by_properties() and restored the original title (I don't understand why it was changed from one function to another in #10).

The function is not used, #7 still applies and does what it says it does, so RTBC.

Hm, so. We recently discussed leaving in the deprecated entity CRUD BC wrappers since we don't gain much other than poking people in the eye by removing them. Let's hold off on committing this until I can get confirmation on that point, at least.

If that's the case, then #2187735: Add removal information to docblock of all @deprecated functions will need to be updated to reflect that. ("will be removed before Drupal 8.0" > "may be removed in Drupal 9.0")

See #2190313: Add $EntityType::load() and loadMultiple() to simplify loading entities, which would allow us to remove or at least deprecate them in favor of something that does not result in reduced DX ( correct type hints for the specific entity type, easy way to call it in procedural code)

I think #12 needs to be addressed before this is RTBC.

Postponed on #2190313: Add $EntityType::load() and loadMultiple() to simplify loading entities

That patch won't apply any more.

We'll also need to update https://www.drupal.org/node/1413672 and ensure this is covered by a change record. IMO the best way to do that is to list the old and new functions on the change record for #2190313: Add $EntityType::load() and loadMultiple() to simplify loading entities.

I have searched for the function - "taxonomy_term_load_multiple()" into entire core drupal 8 and didnt find any usage of this function except the function declaration. Please review.

Fix tag. Please announce at your sprint that the right tag does not include a #.

I Have removed this function in taxonomy.module

#21 removes taxonomy_term_load_multiple() in taxonomy.module.

Change records still haven't been done, see #18

Updated https://www.drupal.org/node/1413672

Thanks for working on this! At this point in the release cycle we can no longer remove functions like these, but we can replace all usages and mark them deprecated by adding @deprecated Deprecated as of Drupal 8.0.0. Use \Drupal\taxonomy\Entity\Term::loadMultiple() instead. to the function's docblock.

+++ b/core/modules/taxonomy/taxonomy.module
@@ -473,29 +473,6 @@ function taxonomy_term_load_multiple_by_name($name, $vocabulary = NULL) {
- * @deprecated in Drupal 8.x, will be removed before Drupal 9.0.
- *   Use \Drupal\taxonomy\Entity\Term::loadMultiple().

there's already one

@timplunkett informed me that this annotation is wrong and all CRUD functions like these are in fact scheduled for removal before Drupal 8.0.0 comes out.

We said we would remove this in 9.x and so we should.

Duplicate of #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch.