Problem/Motivation

InvalidArgumentException: The timestamp must be numeric. in Drupal\Component\Datetime\DateTimePlus::createFromTimestamp()

Steps to reproduce

1. Open the publication_date module
2. Display the Published on field in the display setting of admin/structure/types/manage/CONTENT TYPE/display
3. Create a node with content type d. Do not fill in the data in the Published on field.
4. An error will be reported when clicking preview

Proposed resolution

Add validation on the viewElements method of Drupal\Core\Field\Plugin\Field\FieldFormatter\TimestampFormatter, skip if it is empty

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#11 add-revision-creation-time-3439347-11.patch1019 bytessanjay.maharjan
#8 3439347-8.patch712 bytescharlliequadros
#4 Screenshot from 2024-04-08 12-55-54.png92.1 KBdineshkumarbollu
#3 Screenshot from 2024-04-08 12-26-12.png41.29 KBdineshkumarbollu
#2 3439347-the-timestamp-must-be-numeric.patch1.01 KBrandy tang

Issue fork drupal-3439347

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

    About issue forks

    Comments

    randy Tang created an issue. See original summary.

    randy tang’s picture

    randy tang commented
    StatusFileSize
    new 3439347-the-timestamp-must-be-numeric.patch1.01 KB
    dineshkumarbollu’s picture

    dineshkumarbollu commented
    Assigned: Unassigned » dineshkumarbollu
    StatusFileSize
    new Screenshot from 2024-04-08 12-26-12.png41.29 KB

    +1 for error, i will review patch

    dineshkumarbollu’s picture

    dineshkumarbollu commented
    StatusFileSize
    new Screenshot from 2024-04-08 12-55-54.png92.1 KB

    Patch applied cleanly and fix the issue, Issue also reported in published_date module see https://www.drupal.org/project/publication_date/issues/3424575

    dineshkumarbollu’s picture

    dineshkumarbollu commented
    Assigned: dineshkumarbollu » Unassigned
    cilefen’s picture

    cilefen commented
    Status: Active » Postponed (maintainer needs more info)
    Related issues: +#3424575: InvalidArgumentException: The timestamp must be numeric. in Drupal\Component\Datetime\DateTimePlus::createFromTimestamp() (line 201 of /var/www/html/www/core/lib/Drupal/Component/Datetime/DateTimePlus.php).

    This looks like a workaround. How did this become a Core bug?

    quietone’s picture

    quietone commented
    Status: Postponed (maintainer needs more info) » Closed (works as designed)
    Issue tags: +Bug Smash Initiative

    I agree with #6. And there has been no response for more information here for 4 months so I am closing this as works as designed.

    If you show this is a core bug, then add a comment and reopen the issue.

    Thanks!

    charlliequadros’s picture

    charlliequadros commented
    StatusFileSize
    new 3439347-8.patch712 bytes

    Patch updated to Drupal version 10.3.1.

    paulmckibben’s picture

    paulmckibben
    he/him
    Primary language English
    Location Atlanta, GA
    commented

    I'm seeing this error on a site running Drupal 10.3.4 when I try to look at revisions for a taxonomy term. The revision in question is returning null for getRevisionCreationTime(), and that is leading to the exception described in this issue. I am not able to reproduce it on a clean Drupal 10 install, which leads me to suspect that the problem of the null revision creation time might be an artifact of upgrading this site over the years from Drupal 8 to 9 to 10.

    I don't know whether this is a one-off or some obscure upgrade bug, so I don't think it's worth reopening the issue. Documenting what I found in case it's helpful to somebody else.

    ordasoft’s picture

    ordasoft commented

    Hello

    With "revision" check, the errors fixed like before proposed:
    file:
    core/lib/Drupal/Core/Entity/Controller/VersionHistoryController.php

    code:

    protected function getRevisionDescription(RevisionableInterface $revision): array {
    $context = [];
    if ($revision instanceof RevisionLogInterface  ) {

    replace to code:

    protected function getRevisionDescription(RevisionableInterface $revision): array {
    $context = [];
    if ($revision instanceof RevisionLogInterface && !empty($revision->getRevisionCreationTime() ) ) {

    Regards

    sanjay.maharjan’s picture

    sanjay.maharjan commented
    Version: 10.2.x-dev » 10.3.x-dev
    Status: Closed (works as designed) » Patch (to be ported)
    StatusFileSize
    new add-revision-creation-time-3439347-11.patch1019 bytes

    Hi ,
    I got this issue when i upgraded my project to 10.3.x. As suggested by @ordasoft , code changes in #10 worked for me. I have created the patch with changes from #10.

    Regards,

    smustgrave’s picture

    smustgrave commented
    Version: 10.3.x-dev » 11.x-dev
    Status: Patch (to be ported) » Postponed (maintainer needs more info)

    Will give it another chance but clear steps need to be added to the summary for 11.x. Nothing was committed so porting wasn’t an option

    smustgrave’s picture

    smustgrave commented
    Status: Postponed (maintainer needs more info) » Closed (outdated)

    Since steps haven't been provided going to close out again. If still a bug please feel free to re-open, with steps to reproduce

    Thanks all!

    pfrenssen’s picture

    pfrenssen
    Location Sofia
    commented

    The issue mentioned in comment 9 (#3439347-9: InvalidArgumentException: The timestamp must be numeric. in Drupal\Component\Datetime\DateTimePlus::createFromTimestamp() ) is being addressed here: #3459169: Protect against empty revision timestamps in VersionHistoryController::getRevisionDescription.