Allow "Content ID from URL" contextual filter to recognize node previews

Having the same issue.

Having the same issue.

This is a fortnightly bug smash triage issue, adding tag. Moving to views so the views maintainers will see this (lendude commented in slack that they had not seen this issue).

Some minor updates to the IS.

I think this issue can be addressed in the Node module which provides the default argument to views. Patch attached.

This Patch #15 Looks Good, I have tested in my local and and it worked.

The Needs Review Queue Bot tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Tested #15 and it works absolutely as expected. Only thing that can be an improvement here is using an else if condition rather than if

• Opened a merge request per #17
• changed to elseif as per #18

Issue summary still needs to be completed.

Also as a bug will need a test case showing the issue

Added test and Updated issue summary

Appears to be missing the fix though.

Nope there it is.

Reviewed the MR 5764 and also applied the patch locally. The patch applies cleanly

Checking patch core/modules/node/src/Plugin/views/argument_default/Node.php...
Checking patch core/modules/views/tests/src/Functional/Plugin/ArgumentDefaultTest.php...
Applied patch core/modules/node/src/Plugin/views/argument_default/Node.php cleanly.
Applied patch core/modules/views/tests/src/Functional/Plugin/ArgumentDefaultTest.php cleanly.

Reviewed the issue as per the steps.
The issue gets resolved after applying the patch. i.e. Contextual filter(Content ID from URL) gets applied properly on the node preview page.
Attaching the screenshots.

The Assertions added in the Merge Request runs without any failures. RTBC for me.

@arisen post a screenshot of the patch applying it's needed or useful, we know it applies by the MR being green.

Opening a test only MR is unnecessary so it's hidden.

Running test-only feature of main MR.

1) Drupal\Tests\views\Functional\Plugin\ArgumentDefaultTest::testArgumentDefaultNode
Behat\Mink\Exception\ElementNotFoundException: Element matching xpath "//*[@id="block-view-block-id"]" not found.
/builds/issue/drupal-2978024/vendor/behat/mink/src/WebAssert.php:418
/builds/issue/drupal-2978024/vendor/behat/mink/src/WebAssert.php:457
/builds/issue/drupal-2978024/core/modules/views/tests/src/Functional/Plugin/ArgumentDefaultTest.php:176
/builds/issue/drupal-2978024/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
ERRORS!
Tests: 5, Assertions: 36, Errors: 1.

So removing tests tag.

Left a comment on the MR.

Thanks for reviewing @dan612 and @smustgrave. I have updated the condition to

    $node = $this->routeMatch->getParameter('node') ?? $this->routeMatch->getParameter('node_preview');
    if ($node instanceof NodeInterface) {
      return $node->id();
    }

Moving back to needs review

Believe this is now good.

This issue is changing the UI so adding Usability tag, there should also be screenshots available for reviewers from the Issue Summary.

I then tested this using the steps in the issue summary. I created the problem and then applied the diff and reloaded the preview page. There was no change. After clearing cache the new block was displayed.

I ran the test locally without the fix and it failed as expected. I read the MR which looks fine to me. I also updated credit

Leaving at RTBC

Committed c3c9dd1 and pushed to 11.x. Thanks!