Closed (fixed)
Project:
Page Manager
Version:
8.x-4.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
2 Sep 2015 at 17:09 UTC
Updated:
9 Aug 2024 at 00:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
dsnopekAnd actually, with /node/% it's probably rare that you want something other than [node:title] so that should probably be the default! I made an issue for that as well: #2561949: Default to a "Page title" of [node:title] on variants for a page at /node/%
Comment #3
dsnopekType-o in issue summary.
Comment #4
berdirThe issue that added token support originally had the token browser from token module included but it was removed again to avoid that complexity in the initial branch.
So all we need to do is bring that back. See interdiff in #2287733-27: Configure page title per display
Comment #5
dsnopekWhoa! I thought there wasn't a token browser. Updating the issue summary and title. Thanks! :-)
Comment #6
mmenavas commentedI found out I need to use the [term:name] token to set the title of my taxonomy term page.
Comment #7
andrew.trebble commentedI have taken the token browser code that Berdir wrote and retracted for the token browser in #2287733 and updated it a bit.
I wrapped it in a container because it is now just a link so the "Delete this variant" button moves up to the same line if the token tree link isn't wrapped in a div.
Comment #8
chris.smith commented@andrew.trebble - Trying to review the code. Patch applied to the latest development branch, but not able to see the token browser. Maybe I'm missing something.
Comment #9
chris.smith commented@andrew.trebble - Realized that I was using the Panel variant and your change applies to Block pages. My mistake. Now that I'm testing the right change, I can confirm that this page works.
Reviewed, and seems to work nicely.
Comment #11
berdirThe module dependency is wrong. It should only be a test dependency, not a full dependency.
Comment #12
gambryRe-rolling #7 + removing the token module dependency.
Comment #13
manuel.adanIt works for me. The module handler service is actually injected in the PageBlockDisplayVariant class.
Comment #14
manuel.adanUpdated the target version.
Comment #15
manuel.adanJust another approach, this time adding the token browser link to the title field description for a cleaner result.
Comment #19
japerry