I just ran the migration script, and everything worked great, however I'm a bit concerned about the implications now for on going maintenance with webform:

  • Why is my version of webform in the .info.yml file now 8.x-1.0-beta29?
  • When I first installed webform, I used "composer require drupal/webform", and composer has the version "version": "dev-5.x", and it had a .git folder which I had to remove, but no version was in the .info.yml file
  • When running "`drush yamlform-to-webform-convert`", it seemed like it literally ran through and changed webform's code was that even necessary? How am I supposed to update with webform now? I feel like any update to webform will just wipe out that stuff anyway.

My gut tells me I shouldn't have downloaded via composer, or maybe I did it wrong.

Thanks for the hard work with this, any way to help alleviate these concerns would be much appreciated!
James

My .info.yml when downloaded from composer

name: 'Webform'
type: module
description: 'Enables the creation of webforms and questionnaires.'
package: 'Webform'
core: 8.x
configure: entity.webform.collection
dependencies:
  - 'drupal:system (>= 8.2)'
  - 'drupal:field'
  - 'drupal:user'

My .info.yml after running "drush yamlform-to-webform-convert"

name: 'Webform module custom properties tests'
type: module
description: 'Support module for Webform module custom properties testing, that provides a working example of adding custom properties to elements.'
package: Testing
core: 8.x
# core: 8.x
dependencies:
  - webform
  - webform_ui

# Information added by Drupal.org packaging script on 2016-12-26
version: '8.x-1.0-beta29'
core: '8.x'
project: 'webform'
datestamp: 1482752287

Comments

mcpuddin created an issue. See original summary.

jrockowitz’s picture

jrockowitz commented

@mcpuddin I am really glad you created this ticket.

You absolutely don't need to run the `drush yamlform-to-webform-convert`, just download the latest version of webform-8.x-5.x via drush or composer.

I was using the `drush yamlform-to-webform-convert` to only sync the yamlform to webform module while I finalized the migration.

mcpuddin’s picture

mcpuddin commented

Gotcha

So basically my steps yesterday were:

1) Download webform
2) Run drush yamlform-to-webform-convert
3) Run drush yamlform-to-webform-migrate

It sounds like I didn't actually need to run #2, correct? I must've misread the instructions somehow..

So to undo this, should I just replace the modified webform with the real one and whatever happened with "yamlform-to-webform-migrate" should still be good?

Thanks!
James

jrockowitz’s picture

jrockowitz commented

Yes!!! The migration at this point either works or it does not. The few remaining YAML Form issues, document how to manually fix certain migration problems/bugs.

mcpuddin’s picture

mcpuddin commented

Thanks!

mcpuddin’s picture

mcpuddin commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.