Problem/Motivation

phpunit test results on commit hash: d4ab9c535f4d862a2db34c3d28108db56fa1d482

Remaining deprecation notices (106)

  106x: The \Drupal\Core\Path\AliasManager class is deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Instead, use \Drupal\path_alias\AliasManager. See https://drupal.org/node/3092086
    35x in Fix404RedirectUILanguageTest::testFix404RedirectList from Drupal\Tests\redirect_404\Functional
    31x in Fix404RedirectUITest::testFix404Pages from Drupal\Tests\redirect_404\Functional
    25x in Redirect404LogSuppressorTest::testSuppress404Events from Drupal\Tests\redirect_404\Functional
    15x in Fix404RedirectUITest::testIgnorePages from Drupal\Tests\redirect_404\Functional

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Change records: https://www.drupal.org/node/3092086 and https://www.drupal.org/node/3013865

CommentFileSizeAuthor
#12 Captura de tela de 2020-04-27 09-47-15.png61.03 KBilgnerfagundes
#12 Captura de tela de 2020-04-27 09-47-23.png262.62 KBilgnerfagundes
#9 updated-3116638-7.patch3.55 KBsamvada_jain_m
#6 3116638-6.patch2.8 KBsalah1
#3 xmlsitemap-3116638-1.patch2.8 KBedemidenko

Comments

edemidenko created an issue. See original summary.

edemidenko’s picture

edemidenko commented
Issue summary: View changes
edemidenko’s picture

edemidenko commented
StatusFileSize
new xmlsitemap-3116638-1.patch2.8 KB
edemidenko’s picture

edemidenko commented
Status: Active » Needs review
alex_optim’s picture

alex_optim
Location Tallinn
commented
Status: Needs review » Reviewed & tested by the community

Good work.

salah1’s picture

salah1
Location VA, U.S
commented
Status: Reviewed & tested by the community » Needs review
Parent issue: » #3004330: [META] Prepare module for Drupal 9
StatusFileSize
new 3116638-6.patch2.8 KB

The patch on #3 failed, so uploading a new patch.
I couldn't do interdiff because the patch on #3 failed to apply.
Also, since #3 failed, it won't be RTBC - i thought.
Also, linking this to the parent issue for D9 deprecations and editing the title so this won't appear to be the parent.
Thanks

salah1’s picture

salah1
Location VA, U.S
commented
Title: Drupal 9 Deprecated Code Report » Replace the deprecated Drupal\Core\Path\AliasManagerInterface

Status: Needs review » Needs work

The last submitted patch, 6: 3116638-6.patch, failed testing. View results

samvada_jain_m’s picture

samvada_jain_m commented
Status: Needs work » Needs review
StatusFileSize
new updated-3116638-7.patch3.55 KB

Please review.

neclimdul’s picture

neclimdul
He/Him
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

I must have gotten distracted or searched the wrong queue because I line for line created the same patch and opened #3124240: Replace core AliasManagerInterface with path_alias module. LGTM.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Priority: Normal » Major
ilgnerfagundes’s picture

ilgnerfagundes commented
StatusFileSize
new Captura de tela de 2020-04-27 09-47-23.png262.62 KB
new Captura de tela de 2020-04-27 09-47-15.png61.03 KB

Patch is applying correctly here, rtbc +1

atul4drupal’s picture

atul4drupal commented
Issue tags: +Drupal 9 porting day

Tested and works as expected.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.