Closed (fixed)
Project:
XML sitemap
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
4 Oct 2018 at 13:39 UTC
Updated:
8 Jun 2020 at 19:22 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
volegerI had attached related existing issues as child issues.
For now, I guess is important to define the scopes of replacements. As tests require the conversion to the phpunit-base tests, we should not block them with related replacement issue.
Comment #3
dave reidI believe the only remaining task is to convert legacy tests to PHPUnit tests, but that doesn't prevent the module from working on Drupal 9. I think we're mostly ready!
Comment #4
dave reidComment #5
jenlamptonI believe that if you add drupal 9 as an option to the
composer.jsonfile in this project you can get a nice little Compatible with Drupal 9 badge in the Project information section on the module page.Below is a code sample from a module that has the badge.
It also looks like it may possible to get the badge by adding the 'core_version_requirement' key in the module's info.yml file, which, in turn, will add the version to the require section of
composer.json. Example follows.Does anyone know if this was already included in one of the sub-issues that were marked as fixed? If not, should we create a separate issue for it?
Comment #6
phoang commentedAdding the require version to composer.json file
Comment #7
gábor hojtsyComposer files are not required to specify the Drupal 9 compatibility information. It is enough to have a core_version_requirement in the info file (which is required anyway for Drupal to install it). Neither will show a "Drupal 9 badge" on the project page. You can edit your project and specify the "Drupal 9 porting info" value to make that show up with whatever text you find best describes your project readiness.
Comment #8
pifagor commentedComment #9
pifagor commentedAll related issues are fixed. #3134571: Drupal 9 compatibility is landed. Drupal 9 based test runs are green.
Thanks, everyone for making XMLSitemap module Drupal 9 compatible.
Comment #10
webchickAny idea when we can get a new release so that folks can use an RC/stable vs. a dev release for D9? :)
Comment #12
kporras07 commented+1. A release would be great :)
Comment #13
dave reidPlease help review #3079398: Provide support for entity types without base tables, I'd like to get that ticket in before the next release.