Support all Drupal entities without a custom base class

This seems like a good change. I'm going to wrap it in with another update I'm working on to add a command to generate entity base classes, so it may be a few weeks before I commit this.

I agree this would be a good change. One thing that might be an issue is the static create() method. In WdEntityWrapper it creates a new WdEntityWrapper object. If I understand right, with this change, the new object would have no idea what entity type to use. Probably an easy fix, but just bringing it up.

@brockfanning is correct that the create functionality is an issue. I've reworked the patch to make that functional, and also fixed a several other spots in the provided base classes where it was failing after the changes.

The main issue with this change is that it's going to break sites with a custom entity base class. Since there are only 53 reported installs of this module, and since it only affects users who have written a custom base class and not ones that are only using generated bundle classes, I'm fine with making the API-breaking change. I'll put instructions for fixing at the top of the release notes. (People need to add the $entity_type variable, and remove their constructor, as was done with the provided base classes.)

The specific issue that will break current sites is that I had to reverse the parameters in WdEntityWrapper's constructor. You can now optionally pass an entity type in. If you do, it uses that. Otherwise, it reads from the variable that @pianomansam added.

I just ran a test with this patch applied, and I was able to create an entity with ECK, and then immediately generate wrapper classes for the bundles, without writing any base class. The generated wrapper classes work well, though they do not have methods for the properties of the entity. I'm going to work on that in #2455063: Add scaffold tool for new entity base classes.

Actually, now I've thought of a way to support base entity wrappers written before the constructor change. I've added this code to the beginning of WdEntityWrapper::__construct().

<?php
// Provide a workaround for code written in the pre Issue #2464623 style.
// This constructor used to have arguments ($entity_type, $entity)
if (!is_null($entity_type) && is_string($entity) && (is_object($entity_type) || is_numeric($entity_type))) {
  $actual_entity = $entity_type;
  $entity_type = $entity;
  $entity = $actual_entity;
}
?>

I just dropped this latest version into a project where I wrote several custom entity base wrapper classes as well as used node, user and OG membership bundle wrappers, and it didn't blow up. Functionality all seems intact. Also passes tests on the rewritten base classes included in the patch.

I would appreciate it if some people could test these changes with existing projects or in-development projects where you already have some code written against the module, and report back whether it upgrades cleanly. I think it should at this point.

I'm only in the in-development stage at this point, but I tried updating the module code with this patch, and things still worked. I also tried regenerating all the bundle classes I had generated previously and re-adding my custom changes, and it still worked well.

That's good enough for me. Committed. Thanks. I'll roll out out a new stable release with this change once I get the base entity class scaffolding tool done.

Yes, that made it into the release: https://www.drupal.org/node/2468523