Problem/Motivation

  • Remove container parameter
  • Just return the string ‘live’
  • Remove parameter negotiator
  • Remove negotiator base class

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 interdiff-5.txt3.42 KBamateescu
#6 2921621-5.patch18.87 KBamateescu
#2 2921621-2.patch18.55 KBtimmillwood
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

timmillwood created an issue. See original summary.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Assigned: timmillwood » Unassigned
Status: Active » Needs review
FileSize
2921621-2.patch18.55 KB

Initial stab at this.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented

I missed this part of the discussion in Vienna, so just a quick question for now, why are we removing the parameter negotiator?

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented

@amateescu - the parameter negotiator is not used anywhere. You'll notice it doesn't exist in the current version of Multiversion (http://cgit.drupalcode.org/multiversion/tree/src/Workspace). It was added to Workspace 2.x when we were looking at rendering a "preview" of each workspace in an iframe, so we could load /?workspace=stage and /?workspace=live etc. Now that functionality is on hold or may not even be implemented there's no need for the negotiator to be added.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Needs review » Fixed
FileSize
2921621-5.patch18.87 KB
interdiff-5.txt3.42 KB

Ok, then it makes perfect sense to remove it for now. I did a few minor changes and committed to 8.x-2.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.