Comment Workflow Showing even when Disabled

Hi !

Same issue here.
I solved that problem by replacing in workflow.module this line (l.589) :
if (isset($form['#node'])) {
By this one :
if ($form_id == $form['#node']->type . '_node_form') {

Btw I replaced the comment line (l.599) :
// Abort if user does not want to display workflow form on node editing form.
By that :
// Abort if user does not want to display workflow form on comment form.

Regards.

I am by no means a PHP expert but I think (regardless of this issue) the first 'if' in 'workflow_form_alter' that now reads:

if ((isset($form['#node']) && $form_id == 'comment_node_' . $form['#node']->type . '_form')
|| (isset($form['#node']->type) && isset($form['#node']) && $form['#node']->type . '_node_form' == $form_id)) {
 

should be re-written to something like:

if ((isset($form['#node'])) && (isset($form['#node']->type)) && (($form_id == 'comment_node_' . $form['#node']->type . '_form') || ($form_id == $form['#node']->type . '_node_form'))) {

The second 'if' is superfluous as the first one already checked if $form['#node'] is set (and therefore the 'else' part will never be triggered.

I don't think the solution proposed above is the right one. I've changed my installation as follows:

  if ((isset($form['#node'])) && (isset($form['#node']->type))) {
    $iscomment = ($form_id == 'comment_node_' . $form['#node']->type . '_form');
    $isnode =  ($form_id == $form['#node']->type . '_node_form');
  } else {
    return;
  }
  if ($isnode || $iscomment)  {
      $node = $form['#node'];
      // Abort if user does not want to display workflow form on node editing form.
      if ($isnode && (!in_array('node', variable_get('workflow_' . $form['#node']->type, array('node'))))) {
        return;
      }
      // Abort if user does not want to display workflow form on comment form.
      if ($iscomment && (!in_array('comment', variable_get('workflow_' . $form['#node']->type, array('node'))))) {
        return;
      }

Looking at the definition of variable_get I think

if ($isnode && (!in_array('node', variable_get('workflow_' . $form['#node']->type, array('node'))))) {

may just need to be

if ($isnode && (!in_array('node', variable_get('workflow_' . $form['#node']->type)))) {

as I am not sure why you would provide a default value in this case.

@DrBartje - I think you've got the right idea and I'm pretty sure your code works. I've rewritten it, and attached it as a patch. In my version, I removed isset($form['#node']->type) since if the node object exists, then it should have a type. If it doesn't then it's a bug somewhere else. My version also removes duplicate/redundant code, so as it make it more maintainable.

I've tested the patch from ttkaminski and it seems to work just fine!
Thanks for your work!

grts

fre

tested patch and it works so far

Works good for me also!

Works here as well!

Working well here too! Thank you

#7 RTBC?

Is this still a problem in the current -dev release? Workflows are no longer tied to the comment form.

If someone checks back in and finds this still an issue, reopen it.

I was also having this problem in the latest dev version for D7 and have attached a patch to fix it.

The attached patch is simpler than the one in #7 so is less likely to affect other behaviour. It should also apply cleanly to latest dev version as the patch in #7 is now outdated due to other changes.

Same patch as #16 with unnecessary assignment removed.

Mark, why is the terminal state check being deleted?

I'm not sure what you mean by 'terminal state check' but in the original code the if & the else were doing the same thing:

• Load node.
• Get variable 'workflow_' . $node->type.
• Check whether 'node' or 'comment' was in the variable.

Load node is now done in the shorthand if just in case the node isn't in $form['#node'] (although I'm not sure when it wouldn't be).

Loading the variable was the same but was getting type from different places because of how the $node was loaded so these lines are now the same with a consistent $node before.

Checking for node/comment in the variable can be simplified because $form['#entity_type'] is already set to node/comment for us.

There was a check to see if any states were available and skipping the form if not. That was to check if the node was at the last, or terminal, state.

Do you mean this bit of code:

// Stop if user has no new target state(s) to choose.
if (count($choices) < $min) {
  return;
}

This patch doesn't do anything with that code so it should still be there after the patch is applied.

Committed with attribution. Thanks for the patch.