Depending on the results of #2645494: Redesign moderation form, we *may* want to add weights and descriptions to states and/or transitions. It could be both, it could be just one or the other, that will be dictated by the UX needs. This is just a placeholder issue to add them if and when we decide to do so.

CommentFileSizeAuthor
#18 interdiff-2645516.txt827 bytesCrell
#18 2645516-transition-weight.patch10.55 KBCrell
#14 interdiff-2645516.txt1.54 KBCrell
#14 2645516-transition-weight.patch10.52 KBCrell
#9 2645516-transition-weight.patch14.8 KBCrell
#9 interdiff-2645516.txt2.47 KBCrell
#5 2645516-transition-weight.patch13.53 KBCrell
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Crell created an issue. See original summary.

Crell’s picture

Crell CreditAttribution: Crell at Palantir.net for Acquia commented
Title: Add weight and description to states and transitions » Add weight to transitions
Assigned: Unassigned » Crell
Status: Postponed » Active

Based on Ashley's designs, a weight for the transition would be helpful but not the others at this time. Working on that...

  • Crell committed 9c433cf on 2645516-transition-weight 
    refs #2645516 Add weight field to transitions.

  • Crell committed caafc29 on 2645516-transition-weight 
    refs #2645516 Switch the transition list to a draggable list.
Crell’s picture

Crell CreditAttribution: Crell at Palantir.net for Acquia commented
Status: Active » Needs review
FileSize
2645516-transition-weight.patch13.53 KB

And here we go. I'll integrate with it the revised moderation form code once both are in.

Status: Needs review » Needs work

The last submitted patch, 5: 2645516-transition-weight.patch, failed testing.

The last submitted patch, 5: 2645516-transition-weight.patch, failed testing.

The last submitted patch, 5: 2645516-transition-weight.patch, failed testing.

Crell’s picture

Crell CreditAttribution: Crell at Palantir.net for Acquia commented
Status: Needs work » Needs review
FileSize
interdiff-2645516.txt2.47 KB
2645516-transition-weight.patch14.8 KB

Dur. Why didn't my IDE catch that? Let's fix that and improve the UI a little, too.

Status: Needs review » Needs work

The last submitted patch, 9: 2645516-transition-weight.patch, failed testing.

The last submitted patch, 9: 2645516-transition-weight.patch, failed testing.

The last submitted patch, 9: 2645516-transition-weight.patch, failed testing.

  • Crell committed 44176f0 on 2645516-transition-weight 
    refs #2645516 Use state labels rather than machine names on the...
  • Crell committed e7c60ea on 2645516-transition-weight
    refs #2645516 Fix type hinting.
Crell’s picture

Crell CreditAttribution: Crell at Palantir.net for Acquia commented
Status: Needs work » Needs review
FileSize
2645516-transition-weight.patch10.52 KB
interdiff-2645516.txt1.54 KB

Stupid types. Also let's use the weight now that #2645494: Redesign moderation form is in.

  • Crell committed 3b4c4ad on 2645516-transition-weight 
    refs #2645516 Use state labels rather than machine names on the...
  • Crell committed 593404f on 2645516-transition-weight
    refs #2645516 Add weight field to transitions.
  • Crell committed 5a46e5b on 2645516-transition-weight
    refs #2645516 Actually use the weight now.
  • Crell committed 6080371 on 2645516-transition-weight
    refs #2645516 Switch the transition list to a draggable list.
  • Crell committed 7df0b23 on 2645516-transition-weight
    refs #2645516 Fix type hinting.
becw’s picture

becw CreditAttribution: becw at Palantir.net for Acquia commented 
+++ b/src/Form/ModerationStateTransitionForm.php
@@ -73,6 +73,14 @@ class ModerationStateTransitionForm extends EntityForm {
+      '#description' => $this->t('Optional. In administrative screens, the heavier items will sink and the lighter items will be positioned nearer the top.'),

Not just in administrative screens... also in other moderation interfaces. May I suggest: "Orders the transitions in moderation forms and the administrative listing. Heavier items will sink and the lighter items will be positioned nearer the top"

  • Crell committed 915cdbf on 2645516-transition-weight 
    refs #2645516 Tweak help text.
Crell’s picture

Crell CreditAttribution: Crell at Palantir.net for Acquia commented
FileSize
2645516-transition-weight.patch10.55 KB
interdiff-2645516.txt827 bytes

Yep, sounds good.

  • Crell committed 3b4c4ad on 8.x-1.x 
    refs #2645516 Use state labels rather than machine names on the...
  • becw committed 4886005 on 8.x-1.x
    Issue #2645516 by Crell: Add weight to transitions
  • Crell committed 593404f on 8.x-1.x
    refs #2645516 Add weight field to transitions.
  • Crell committed 5a46e5b on 8.x-1.x
    refs #2645516 Actually use the weight now.
  • Crell committed 6080371 on 8.x-1.x
    refs #2645516 Switch the transition list to a draggable list.
  • Crell committed 7df0b23 on 8.x-1.x
    refs #2645516 Fix type hinting.
  • Crell committed 915cdbf on 8.x-1.x
    refs #2645516 Tweak help text.

The last submitted patch, 14: 2645516-transition-weight.patch, failed testing.

The last submitted patch, 14: 2645516-transition-weight.patch, failed testing.

The last submitted patch, 14: 2645516-transition-weight.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 18: 2645516-transition-weight.patch, failed testing.

The last submitted patch, 18: 2645516-transition-weight.patch, failed testing.

The last submitted patch, 18: 2645516-transition-weight.patch, failed testing.

Crell’s picture

Crell CreditAttribution: Crell at Palantir.net for Acquia commented
Status: Needs work » Fixed

Snafoo with another patch. This was committed and everything is green.

becw’s picture

becw CreditAttribution: becw at Palantir.net for Acquia commented

Nice. Transition ordering in moderation form buttons and an updated transition listing in the admin UI! It all looks good.

I merged before the tests finished (sorry), but the 8.x-1.x branch is green now, so we're good to go.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.