Problem/Motivation

The moderation form should show the current state of the entity, the states that it can be transitioned to, maybe descriptions of them. The commands to transition states could be based on the transition or the state. TBD. It should also have some way to trigger a transition. Select box? Buttons? Other?

Let's figure out what this control should do.

Proposed resolution

Designers, tell us what we should do here.

Remaining tasks

Design a better form, which will also indicate what else we need to improve elsewhere.

User interface changes

That's the point. :-)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Crell created an issue. See original summary.

aCyborg’s picture

Assigned: aCyborg » Crell
FileSize
85 KB

After discussing with the team, I think that this mock will help solve this issue as well as a label string with "Save and" attached to the transition labels as follow (default):

  • Draft > Draft : Create New Draft
  • Draft > Needs Review : Request Review
  • Draft > Published : Publish
  • Needs Review > Needs Review : Keep in Review
  • Needs Review > Published : Publish
  • Published > Archive : Archive
  • Published > Draft : Create New Draft
  • Published > Published : Publish

  • Crell committed 3e4aa00 on 2645494-moderation-form
    refs #2645494 Adjust labels of default transitions.
    
  • Crell committed 6973ca8 on 2645494-moderation-form
    refs #2645494 Revise moderation form content.
    
  • Crell committed ae4d01e on 2645494-moderation-form
    refs #2645494 Refactor the moderation state widget to use transition...
Crell’s picture

This is still a WIP, but putting it up there. Will continue working tomorrow.

Status: Needs review » Needs work

The last submitted patch, 4: 2645494-moderation-form.patch, failed testing.

The last submitted patch, 4: 2645494-moderation-form.patch, failed testing.

The last submitted patch, 4: 2645494-moderation-form.patch, failed testing.

  • Crell committed 44e0091 on 2645494-moderation-form
    refs #2645494 Documentation and cleanup.
    

  • Crell committed b362b20 on 2645494-moderation-form
    refs #2645494 Add a revision log field to the moderation form.
    

  • Crell committed 3553a0d on 2645494-moderation-form
    refs #2645494 Adjust labels of default transitions.
    
  • Crell committed 47100d8 on 2645494-moderation-form
    refs #2645494 Documentation and cleanup.
    
  • Crell committed c0cc415 on 2645494-moderation-form
    refs #2645494 Revise moderation form content.
    
  • Crell committed da457a0 on 2645494-moderation-form
    refs #2645494 Refactor the moderation state widget to use transition...
  • Crell committed dc18785 on 2645494-moderation-form
    refs #2645494 Add a revision log field to the moderation form.
    

  • Crell committed f2f5513 on 2645494-moderation-form
    refs #2645494 Retheme the moderation form to be horizontal.
    
Crell’s picture

And here's a real version! Branch has also been rebased.

The alignment on the form is a little off. It is probably good to have Ashley take a look.

This does not add weights to transitions. I figure that's best done as a separate issue, and is trivial enough to integrate here later. (It's probably a one line change to leverage.)

Note that you'll need a fresh install to see the changes to the config files, because Drupal. :-)

Status: Needs review » Needs work

The last submitted patch, 12: 2645494-moderation-form.patch, failed testing.

The last submitted patch, 12: 2645494-moderation-form.patch, failed testing.

The last submitted patch, 12: 2645494-moderation-form.patch, failed testing.

  • Crell committed e3f9b29 on 2645494-moderation-form
    refs #2645494 Improve error handling for newly created entities.
    
Crell’s picture

Priority: Normal » Major

Status: Needs review » Needs work

The last submitted patch, 18: 2645494-moderation-form.patch, failed testing.

The last submitted patch, 18: 2645494-moderation-form.patch, failed testing.

The last submitted patch, 18: 2645494-moderation-form.patch, failed testing.

  • Crell committed efbc880 on 2645494-moderation-form
    refs #2645494 Fix permissions and button labels in Simpletest.
    

  • Crell committed 570c5cf on 2645494-moderation-form
    refs #2645494 Fix more Simpletest strings.
    

  • Crell committed 096a62b on 2645494-moderation-form
    refs #2645494 Retheme the moderation form to be horizontal.
    
  • Crell committed 2a153c5 on 2645494-moderation-form
    refs #2645494 Add a revision log field to the moderation form.
    
  • Crell committed 3914e54 on 2645494-moderation-form
    refs #2645494 Adjust labels of default transitions.
    
  • Crell committed 4cb88ec on 2645494-moderation-form
    refs #2645494 Fix permissions and button labels in Simpletest.
    
  • Crell committed 599f00c on 2645494-moderation-form
    refs #2645494 Fix more labeling in tests.
    
  • Crell committed 6f93da9 on 2645494-moderation-form
    refs #2645494 Documentation and cleanup.
    
  • Crell committed b5a2cad on 2645494-moderation-form
    refs #2645494 Refactor the moderation state widget to use transition...
  • Crell committed c1f812f on 2645494-moderation-form
    refs #2645494 Improve error handling for newly created entities.
    
  • Crell committed cfd11aa on 2645494-moderation-form
    refs #2645494 Fix more Simpletest strings.
    
  • Crell committed d388baa on 2645494-moderation-form
    refs #2645494 Unbreak the moderation form by using Twig with forms...
  • Crell committed ead065c on 2645494-moderation-form
    refs #2645494 Fix strings in Simpletest.
    
  • Crell committed edd222c on 2645494-moderation-form
    refs #2645494 Revise moderation form content.
    
Crell’s picture

Status: Needs review » Needs work

The last submitted patch, 25: 2645494-moderation-form.patch, failed testing.

The last submitted patch, 25: 2645494-moderation-form.patch, failed testing.

The last submitted patch, 25: 2645494-moderation-form.patch, failed testing.

Crell’s picture

  • Crell committed 096a62b on 8.x-1.x
    refs #2645494 Retheme the moderation form to be horizontal.
    
  • becw committed 1636f92 on 8.x-1.x
    Issue #2645494 by Crell: Redesign moderation form
    
  • Crell committed 2a153c5 on 8.x-1.x
    refs #2645494 Add a revision log field to the moderation form.
    
  • Crell committed 3914e54 on 8.x-1.x
    refs #2645494 Adjust labels of default transitions.
    
  • Crell committed 4cb88ec on 8.x-1.x
    refs #2645494 Fix permissions and button labels in Simpletest.
    
  • Crell committed 599f00c on 8.x-1.x
    refs #2645494 Fix more labeling in tests.
    
  • Crell committed 6f93da9 on 8.x-1.x
    refs #2645494 Documentation and cleanup.
    
  • Crell committed b5a2cad on 8.x-1.x
    refs #2645494 Refactor the moderation state widget to use transition...
  • Crell committed c1f812f on 8.x-1.x
    refs #2645494 Improve error handling for newly created entities.
    
  • Crell committed cfd11aa on 8.x-1.x
    refs #2645494 Fix more Simpletest strings.
    
  • Crell committed d388baa on 8.x-1.x
    refs #2645494 Unbreak the moderation form by using Twig with forms...
  • Crell committed ead065c on 8.x-1.x
    refs #2645494 Fix strings in Simpletest.
    
  • Crell committed edd222c on 8.x-1.x
    refs #2645494 Revise moderation form content.
    
becw’s picture

Status: Needs review » Fixed

Beautiful.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.