Problem/Motivation
The moderation form should show the current state of the entity, the states that it can be transitioned to, maybe descriptions of them. The commands to transition states could be based on the transition or the state. TBD. It should also have some way to trigger a transition. Select box? Buttons? Other?
Let's figure out what this control should do.
Proposed resolution
Designers, tell us what we should do here.
Remaining tasks
Design a better form, which will also indicate what else we need to improve elsewhere.
User interface changes
That's the point. :-)
| Comment | File | Size | Author |
|---|---|---|---|
| #29 | interdiff-2645494.txt | 1.28 KB | Crell |
| #29 | 2645494-moderation-form.patch | 33.66 KB | Crell |
| #2 | moderation-form-ui.png | 85 KB | aCyborg |
Comments
Comment #2
aCyborg commentedAfter discussing with the team, I think that this mock will help solve this issue as well as a label string with "Save and" attached to the transition labels as follow (default):
Comment #4
Crell commentedThis is still a WIP, but putting it up there. Will continue working tomorrow.
Comment #12
Crell commentedAnd here's a real version! Branch has also been rebased.
The alignment on the form is a little off. It is probably good to have Ashley take a look.
This does not add weights to transitions. I figure that's best done as a separate issue, and is trivial enough to integrate here later. (It's probably a one line change to leverage.)
Note that you'll need a fresh install to see the changes to the config files, because Drupal. :-)
Comment #17
Crell commentedComment #18
Crell commentedThis should fix a bunch of those Simpletest issues, maybe all?
Comment #25
Crell commentedOK, I think I got it this time. Also, yay test for finding form bugs!
Comment #29
Crell commentedI swear, I know how to code.
Comment #31
becw commentedBeautiful.