CommentFileSizeAuthor
#7 weight-feeds-target-3006002-7-8.patch991 bytesartematem
#6 weight-feeds-target-3006002-6-8.patch978 bytesartematem
#5 weight-feeds-target-3006002-5-8.patch450 bytesartematem
#4 weight-feeds-target-3006002-4-8.patch450 bytesartematem

Comments

artematem created an issue. See original summary.

ziomizar’s picture

ziomizar commented
Related issues: +#2844849: Does this module work with Feeds?
ziomizar’s picture

ziomizar commented
Related issues: +#2997019: Mapping for Ubercart Price and Attributes For Drupal 8
artematem’s picture

artematem commented
Status: Active » Needs review
StatusFileSize
new weight-feeds-target-3006002-4-8.patch450 bytes

Adding patch

artematem’s picture

artematem commented
StatusFileSize
new weight-feeds-target-3006002-5-8.patch450 bytes

Updated comment in file.

artematem’s picture

artematem commented
StatusFileSize
new weight-feeds-target-3006002-6-8.patch978 bytes

Move Plugin to submodule to handle Feeds module dependency.

artematem’s picture

artematem commented
StatusFileSize
new weight-feeds-target-3006002-7-8.patch991 bytes

Fix namespace.

ziomizar’s picture

ziomizar commented

Hi @artematem,

Thanks a lot for this! I would like to go for #4 and #5 they don't need to declare the dependency on feeds module, that code will run just if the feeds module is installed.

ziomizar credited MegaChriz.

ziomizar’s picture

ziomizar commented
Issue summary: View changes
ziomizar’s picture

ziomizar commented
Issue summary: View changes

Added credits to MegaChriz for his suggestions on slack.

ziomizar’s picture

ziomizar commented
Status: Needs review » Reviewed & tested by the community

  • ziomizar committed c080975 on 8.x-3.x authored by artematem 
    Issue #3006002 by artematem, MegaChriz: Does this module (8.x) work with...
ziomizar’s picture

ziomizar commented
Status: Reviewed & tested by the community » Fixed

Tested the patch on #5 it works fine, feel free to reopen it if you found some problem here.

Thanks

artematem’s picture

artematem commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

summit’s picture

summit commented

Hi, Thanks for the patch, but this patch seems not be committed, or do I see something false?
greetings, Martijn