Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Websnapr has upgraded it's code. Therefore, the module shows only one image with the hint "Please update your websnapr code".
Comment | File | Size | Author |
---|---|---|---|
#10 | websnapr_field-1243902-10.patch | 1.74 KB | Dane Powell |
#9 | websnapr_field-1243902-8.patch | 1.32 KB | discipolo |
#7 | websnapr_field-1243902-7.patch | 1.19 KB | discipolo |
Comments
Comment #1
Dane Powell CreditAttribution: Dane Powell commentedsub- websnapr_field is completely useless until this is resolved.
Comment #2
gzett CreditAttribution: gzett commentedThe problem with the new Websnapr code is, that they are using javascript. The javascript file must be loaded from websnapr, because they are using a hash code, to check the age of the file. But Drupal 6 does not support external js-files.
I have a suggestion for the problem:
Comment #3
jvinci CreditAttribution: jvinci commentedfollowing
Comment #4
queryblitz CreditAttribution: queryblitz commented+1
Comment #5
monstordh CreditAttribution: monstordh commentedHas anyone used this code? Does it resolve the issues with the new code without any problems?
Comment #6
discipolo CreditAttribution: discipolo commentedindeed, it works
Comment #7
discipolo CreditAttribution: discipolo commentedreuploading as patch
Comment #8
Dane Powell CreditAttribution: Dane Powell commentedAre you guys aware that this has already been "fixed" in dev? See #1062678: new websnapr code
Note that they take a rather different approach to solving this there- loading the script on hook_init(). I think the approach in #7 is probably better as it doesn't use hook_init(), but I'm not sure. Thoughts?
Note that the patch in #7 is not a valid Git patch and needs to be re-rolled WRT 6.x-dev regardless.
Comment #9
discipolo CreditAttribution: discipolo commentedtry of reroll
Comment #10
Dane Powell CreditAttribution: Dane Powell commentedOkay, here's a patch WRT HEAD. It adopts the 'meat' of the code added by the other issue, #1062678: new websnapr code, but removes the hook_init() and replaces it with the drupal_add_js() proposed in #9. I've tested it and it seems to work fine.