Closed (fixed)
Project:
Webform Protected Downloads
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
16 Nov 2016 at 14:05 UTC
Updated:
21 Oct 2020 at 19:24 UTC
Jump to comment: Most recent
Comments
Comment #2
berliner commentedNow with webform 8 approaching stable, this becomes actually an option. So yes, I might start working on this in the next couple of months.
Help is always appreciated in any form!
I'll update this issue once I created the 8.x branch.
Comment #3
sam mooreI'd also like to see this happen - please post when we can contribute in any way.
Cheers, and thanks for a useful module.
Comment #4
shr0p commentedHi there. Thanks for a great module. Is there any update on Drupal 8 support?
Comment #5
niekheezemans commentedAm interested too in a Drupal 8 version.
Comment #6
niekheezemans commentedAny updates on the start of developing this functionality?
Comment #7
timotejl commentedI went ahead and created a prototype module. The code is available here. Feel free to provide some feedback.
Comment #8
berliner commentedThanks timotejl! I'll try to find some spare time soon to have a look at your prototype.
Can you already give some details about the amount of functionality that is covered compared to the 7.x branch?
Comment #9
c_archer commentedHi,
I have tested the module on Github and found a couple of issues, raised issues on Github.
Thanks,
Chris
Comment #10
nkoporecHi.Tested timotejl module and it's working fine, he fixed the issues that c_archer raised.
Comment #11
timotejl commentedSince Webform for D8 is quite different I started this module from scratch. Webform is no longer bound to a specific node, therefore we're no longer using node fields to hold the download files.
The basic functionality should be now working, including a possibility to add expiration time and enable one-time download links. A custom token can be used to output the link on form confirmation or send it via email. The module currently supports one file per form. Some replacement tokens like expiration date have not yet been implemented.
Comment #12
boshtian commentedTested the module and it looks like a good piece of work. I think that this could already become a D8 dev release as the basic functionality is there and working.
berliner - I would suggest you create a 8.x dev branch and we can work through issues from there on if we want to add new features to this module in the future.
Comment #13
dddbbb commentedAlso been testing the module on GitHub and agree that this would benefit from a dev release here.
Failing that, @timotejl, please consider publishing your module here on D.O under a different name.
Comment #14
berliner commentedI have reached out to @timotejl to propose co-maintaining this module here, so far I didn't hear back from him.
I agree that this should get a release here, but I don't have the resources right now to maintain the D8 branch.
Comment #15
timotejl commentedHi @berliner, I tried contacting you back, seems like your email address is not able to receive messages.
Comment #16
boshtian commented@berliner, can we get this moving? We really need to create a Drupal 8 branch, so people can start using this module.
Comment #17
berliner commentedSorry @all, I had issues with my mail account that I use for drupal.org and I didn't notice. I have added timotejl as a co-maintainer now.
Comment #18
berliner commented@timotejl Any news on the D8 version?
Comment #19
mikael berger commentedI am very interested in a D8 version too.
There seems to be an issue with the token storage - which I have reported at GitHub - but otherwise this seems to be a decent beta.
I am not really an expert php programmer but I will try to help anyway if I can.
As far as I can see, this is module is a "must" and IMHO it is high time to move it to drupal.org ;)
Comment #20
kswamy commented@timotejl, @Mikael Berger Any update on this module? It would be great if one of you can complete this port over.
Could you also update what are the pending issues which is preventing this from being ported over.
Comment #21
kswamy commented@berliner @timotejl Could you please update on the current status for D8 for this module and when we can expect a beta version ?
I see the code is available at https://github.com/timlovrecic/Webform-Protected-Downloads. Could someone please confirm if we can use this or if you can move it to Drupal?
Comment #22
kswamy commentedHave updated the GitHub code to fix an minor issue. Please merge the PR
Comment #23
philyHi,
GitHub code seems to be working fine on a Drupal 8.7.3 project (PHP 7.2).
Thanks
Comment #24
philyMight be usefull to transliterate the filename.
Issued in https://github.com/timlovrecic/Webform-Protected-Downloads/issues/10
Comment #25
dbroll commented+1 for the Github version Drupal 8.9 with the token [webform_submission:protected_download_url].
It would be nice to get this moved over to the Drupal site.
Comment #26
berliner commentedJust added devkinetic as a maintainer. So this issue should finally get some progress.
Sorry for the delay and thanks to devkinetic to take on the maintainership for the D8 version.
Comment #27
devkinetic commentedI've just created a new release, 8.x-1.x-dev which is a direct fork of the github repo. My best friend is getting married next week, so bear with me, but if you wonderful people can start creating ports of the work hanging around on github? I can quickly get those rolled in, but anything more than "make it work in D8" will be after life stuff.
Comment #28
devkinetic commentedI'm beginning some internal testing of the dev version. Closing this issue so discussion can move to dedicated issues in the queue.
Comment #29
devkinetic commentedPlan added to #3175606: [PLAN] 8.x-1.0 Release.