Closed (fixed)
Project:
Webform Ajax
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
1 Oct 2013 at 11:57 UTC
Updated:
10 Apr 2019 at 08:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Andrew Gorokhovets commentedsubscribe
Comment #2
swim commentedHmm, I got this working a few weeks ago (although my situation was very ad hoc) it was fairly simple. I'll throw a patch together tonight.
I think it's related to; classes over id's.
Comment #3
swim commentedAhh apparently we need both now. Unless I'm being stupid.
Working patch attached.
Comment #3.0
swim commentedspelling
Comment #4
petabyte commentedSee status change message.
Comment #5
petabyte commentedDid a review and can confirm that this patch fixes the compatibility issue for Webform Ajax 7.x-1.x-dev (from Oct, 26th 2013) and Webform 7.x-4.0-beta1. Thanks hapax!
Comment #6
Derimagia commentedLooks like the reason the id change was necessary is because of webforms's pre_render function 'webform_pre_render_remove_id' which removes the #id.
Comment #7
ekidman commentedThanks for the patch. However, after the patch is applied, I get a message that states:
"An error occurred while attempting to process /system/ajax: Object [object Object] has no method 'ajaxSubmit'" (Chrome)
"An error occurred while attempting to process /system/ajax: ajax.form.ajaxSubmit is not a function" (Firefox)
I'm also loading the webform in a Colorbox via Colorbox_Node. Not sure if this relates to Webform AJAX at all, but hopefully someone has some insight.
Webform 7.x-4.0-beta1
Webform AJAX 7.x-1.1
Comment #8
swim commented@ #7 it sounds like you need to include the Ajax library...
Comment #9
ekidman commentedGood call, that fixed it. Thanks.
Comment #10
marcusx commentedCan confirm that this makes the ajax working with webforms 4.x.
Comment #11
karlsheaConfirm this works with Webform 4.x in a block inside a panel
Comment #12
Daemon_Byte commentedHas anyone got this working for multi-step?
Comment #13
miro_dietikerHint: I have added maintainer access for swim and drastik on behalf of their request.
I hope they find time to take care of this issue.
Comment #14
swim commentedThanks Miro,
I'll roll a new dev release ASAP (tonight hopefully). This issue might span to multistep webforms although I didn't encounter any problems with this feature.
Comment #16
eternallight commentedGuys, thank you for the working patch but unfortunately it has caused another issue. After applying, Clientside Validation Webform stopped working on submit. Could you please consider the compatibility with this module in the further releases?
Solution found:
Enable the Validate before AJAX call option in the settings of the specific webform's Client Validation. Sorry for disturbing.
Comment #17
abacaba commentedHi guys, I have done that if you apply a patch to correct this comment creates html button code automatically https://www.drupal.org/node/2102029#comment-8010383
Comment #18
rajab natshahHi,
I'm not sure if this issue will be patched in the next version.
Rewarded :)
Comment #19
garethhallnz commentedI have 7.x-1.1 installed and the committed patch form #15 does not work. The form submits.
Patch #17 . Specifically
fixed the issue.
Comment #20
torotil commentedI can't reproduce #1548610: Ajax-webform in block ajaxifies other forms on that page after validation at all with the current Drupal 7.50 / webform 4.x. This might be due to changes in Drupal-core especially the ajax_html_ids data-structure that is used to seed drupal_html_id() on each AJAX request.
Unless someone else can still reproduce the core-issue I'd vote for removing the workaround instead of fixing it for webform4.
Comment #21
hkirsman commentedDoesn't work for me. Tried dev version and different alterations stated here. Id doesn't seem to matter. Downgrading Webform back to 3.
Comment #22
hkirsman commentedHere's the button source code.
Comment #23
torotil commentedI’m using the patch from #20 since more than 2 years on several sites now. It works for me.
Comment #24
torotil commentedComment #27
torotil commentedI have committed #20 to the new 7.x-2.x branch (webform4 only).
It seems the underlying issue described in #6 was fixed in #2438363: Need to add check for ajax in webform_pre_render_remove_id which was released as part of webform-7.x-4.4. I’ve also bumped the webform dependency accordingly.