Notice: Undefined index: exclude_empty

if ($email && (array_key_exists('exclude_empty',$email) && $email['exclude_empty']))

can be changed to :

if ($email && isset($email['exclude_empty']))

Also change status to "Needs Review" after submitting a patch. :)

This should be fixed in webform2pdf, which is creating the incomplete email. Or is there a reason it can't?

We avoid adding tests for data that must be there.

Moving to the webform2pdf issue queue for further development.

But why we can't reinsured and add isset()? This simple check prevent for future notices.

Better to check array indexes than not to check.

I've also created a patch to Webform (https://www.drupal.org/node/2601546).

What we gonna do with this?

I'm curious at where this issue stands. I am experiencing this issue when using the webform2pdf module as well.I've following related issue links that have gone from that module over the webform, back to webform2pdf, and once again back to webform.

To be honest I'm not sure what the recommended patch to use is anymore. Can someone set me straight? Thanks!

I took the path of least resistance here and applied this patch (it seemed the simplest and least intrusive) : webform-exclude_empty-2499749-6.patch

I can confirm that the error message is gone. I have some more testing to do, but so far so good.

@ladybug_3777, this patch is correct.

Thank you Br0kEN!

I had the same issue and patch "webform-exclude_empty-2499749-6.patch" solves it.

Thanks!

Regards,
Michel.