Closed (works as designed)
Project:
Webform
Version:
6.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Dec 2020 at 18:57 UTC
Updated:
2 Jan 2021 at 18:05 UTC
Jump to comment: Most recent
Comments
Comment #2
jacov commentedi have installed webform6 on previous d9.0 releases with some hacking, but it worked and showed up...here now it is not even showing up...
Comment #3
jrockowitz commentedBased on https://www.drupal.org/project/webform/releases/6.x-dev the below command should work as expected.
composer require 'drupal/webform:6.x-dev@dev'Did you clear composer's cache?
Are you able to replicate this via a clean composer install?
Comment #4
jacov commentedComment #5
jacov commentedThanks Jacob, but still not working...
I just tried;
and still not working :-(
"...
Are you able to replicate this via a clean composer install?
..."
...that i will have to try and replicate...currently trying to add it to existing app hosted on Acquia Cloud Professional which was a gradual upgrade from early 9.x release...so "clean" in this case is not an option, if anything, i will have to rebuild / refactor new app with same modules and import config on separate docroot.
...about a month ago or so, i did install webform 6 on d9 in a clean install, but it was 9.0 and 9.2-dev, not 9.1...
thanks for your hard work on this great project, been using for years, and have implemented in some of the biggest sites in the world.
good shabbas
Comment #6
jacov commented@jrockowitz could this be a vendor folder / directory structure issue?
i ran clean install command as follows:
And it creates the following structure:
However, my existing app, follows the old original previous Acquia Cloud default Drupal directory structure where vendor folder lives inside the web docroot, like so:
could this be the issue?
do i need to rewire paths in composer.json file to fix this? or can module take this into account like other modules.
For example, i don't have this problem with the following modules:
^ all those modules working with d9.1 and vendor folder inside web docroot
Comment #7
jacov commentedok, yeah...
i refactored and rearranged folders and reinstalled and it worked, module is showing up...(in dev and stage livedev env, NOT in prod with prod mode enabled - secure folders)
we can resolve this issue here, but you may want to fix it to be more like other modules who take this into consideration and are compatible with both structures...
could possibly help for adoption, especially on ACP and other legacy backwards compat
Comment #8
jacov commentedComment #9
jacov commentedafter rearranging files, i was able to enable the module via drush, even though it did not show up in Extend, however site blew up and got this error:
this is most likely related to the problem...
Comment #10
jacov commentedre-opening, since still...other modules don't have this problem...something different with how webform is bootstrapping / looking for root, or some permission dependency issue here...
...plus, unrelated / maybe reelated i noticed .git directory is checked into dev version...
@jrockowitz you can decide what to do with this
Comment #11
jrockowitz commentedUnless someone else is able to replicate this issue. I am not sure there anything that can be done.
Comment #12
jacov commentedok solved 100%
this was because the dev module has a .git folder checked in, which confused my repo and caused the contents of the webform module to be empty; after cleaning up the webform/.git folder and committing code again, issue resolved, basically had to:
Comment #13
japerryRelated issue I think: https://www.drupal.org/project/coder/issues/2939229
Comment #14
jrockowitz commentedAll dev modules via composer will have .git folder downloaded. If you need to commit all the contrib modules to .git, you will need to remove .git directories.
Pantheon requires all contrib modules to be committed and they offer some suggestions on how to handle Git submodules.
@see https://pantheon.io/docs/guides/partial-composer