The configuration override is not working as expected when we try to extend the settings.

Steps to Replicate:

Step 1:
Install `config_override` module and enable it.

Step 2 :
In our custom module copy the `webform.settings.yml` file from `webform` and place it under `config\override` and update the changes required.

Step 3 :
Login in as admin and see the updated settings was visible there through ui ["admin/structure/webform/config "]

The found this occurs when i try to extend `third_party_settings` settings. When i looked into it it seems like in `WebformThirdPartySettingsManager.php` line no 9 it should be $this->config = $this->configFactory->get('webform.settings') rather than $this->config = $this->configFactory->getEditable('webform.settings')

CommentFileSizeAuthor
#5 3029775-5.patch593 bytesjrockowitz
#3 3029775-3.patch0 bytesjrockowitz

Comments

santhosh.fernando created an issue. See original summary.

santhosh.fernando’s picture

Issue summary: View changes
jrockowitz’s picture

Status: Needs work » Needs review
StatusFileSize
new0 bytes

Status: Needs review » Needs work

The last submitted patch, 3: 3029775-3.patch, failed testing. View results

jrockowitz’s picture

Status: Needs work » Needs review
StatusFileSize
new593 bytes
santhosh.fernando’s picture

@jrockowitz that is a fast response. Thank you..

  • jrockowitz committed bd79bfb on 8.x-5.x
    Issue #3029775 by jrockowitz, santhosh.fernando: Config override is not...
jrockowitz’s picture

Status: Needs review » Fixed

Thanks for the thorough description.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.