After the update to include DISPLAY WRAPPER ATTRIBUTES on the Advanced tab of elements, I found this typo for which I detail below
# This patch file was generated by NetBeans IDE
# It uses platform neutral UTF-8 encoding and \n newlines.
--- a/WebformElementBase
+++ b/WebformElementBase
@@ -2908,7 +2908,7 @@
$form['display']['format_attributes']['format_attributes'] = [
'#type' => 'webform_element_attributes',
'#title' => $this->t('Display'),
- '#class__description' => $this->t("Apply classes to the element's display wrapper. Select 'customâ' to enter custom classes."),
+ '#class__description' => $this->t("Apply classes to the element's display wrapper. Select 'custom' to enter custom classes."),
'#style__description' => $this->t("Apply custom styles to the element's display wrapper."),
'#attributes__description' => $this->t("Enter additional attributes to be added to the element's display wrapper."),
'#classes' => $this->configFactory->get('webform.settings')->get('element.wrapper_classes'),
Don't know how else to let you know about this very minor typo
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | customtext.png | 15.21 KB | taxicab221 |
| #2 | Screen Shot 2018-11-25 at 5.24.25 AM.png | 39.99 KB | jrockowitz |
Comments
Comment #2
jrockowitz commentedWhat admin theme are you using? The ellipsis look okay in the Seven admin theme.
Comment #3
taxicab221 commentedSorry @jrockowitz . I choose the wrong version.
Have updated the version number.
Comment #4
jrockowitz commentedOkay, it is not the theme. We need to figure out how to replicate this issue.
What browser/OS are you using?
What is the default language of your website?
Comment #5
jrockowitz commentedI can also confirm that webform is using the UTF-8 ellipse character.
@see #44987: [meta] Use the UTF-8 ellipsis character instead of "..." in the user interface
Comment #6
taxicab221 commentedSite Information :
Sorry for a long post, but wanted to detail all that I have done so this can be resolved. If more information is required, I will post as soon as I can.
This Drupal test site and all required modules were installed onto my Xampp installation using Composer about 2 days ago.
Most were installed from the composer cache.
Since this issue, I have run the composer update
Then I ran composer clearcache
Then re-ran composer update
Then I decided to install a testsite using composer. As you can see from the output from the CMD window all but a couple were Downloaded, not from the cache.
I then compared the new installed
C:\xampp\htdocs\dombarrett.local\modules\contrib\webform\src\Plugin\WebformElementBase.phpfile with my existing sitesC:\xampp\htdocs\testsite\modules\contrib\webform\src\Plugin\WebformElementBase.phpfile and found these differences in my existing WebformElementBase.php file.These difference were also the same as in the Webform module downloaded zip file from
https://www.drupal.org/project/webform/releases/8.x-5.0-rc26Conclusion
There as been a code change between the first time I install the Webform module, installed again from the composer cache and a fresh install after clearing the composer cache.
Running
composer updatedoes not update any changes in the files even after runningcomposer clearcache.Also checked the file sizes.
C:\xampp\htdocs\dombarrett.local\modules\contrib\webform\src\Plugin\WebformElementBase.php - 124,276 bytesC:\xampp\htdocs\testsite\modules\contrib\webform\src\Plugin\WebformElementBase.php - 120,077 bytesW:\Downloads\FireFox\expanded\webform-8.x-5.0-rc26\webform\src\Plugin\WebformElementBase.php - 120,077 bytesComment #7
jrockowitz commentedI think the issue is Windows handling of UTF-8. I will do a little research.
Comment #8
jrockowitz commentedSo I can't reproduce this issue using MSEdge Window 10 with IE, Chrome, or Firefox.
I am curious if you see this issue via https://simplytest.me? or with other browsers?
@taxicab221 We both are spending a lot of time on this issue and I am will to bet that this might be local development environment issue. We should confirm that this only impacts your local environment and possibly mark this as won't fix.
Comment #9
taxicab221 commentedThanks for your time.
Looks like it may have been a local problem on my computer. Will spend more time looking to find what caused this.
For now, I will close this Issue.