Active
Project:
Views Slideshow: Dynamic Display Block
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
19 May 2010 at 13:17 UTC
Updated:
11 Jun 2010 at 09:37 UTC
Jump to comment: Most recent file
Comments
Comment #1
ppblaauw commentedThis behavior is by design.
The number of items used for the scrollable pager determines when the scrollable pager should scroll.
The number of items is not for showing a certain number of items. When you want to show less or more items in the scrollable pager you need to adjust the size available for scrollable pager items and the size of a scrollable pager item in CSS.
Hope this helps you further, please let me know.
Comment #2
SweeneyTodd commentedOK.
I have changed this to a Feature Request.
Could you add the number of page items to the class for the pager and then have multiple classes in the css file to automatically resize / reposition the pager based on the number selected? If the number of pictures available is less than the number selected in the view configuration, then this could be used to override the pager config to reduce the size / reposition the pager and keep things looking tidy.
If you do not think this is worth doing, then Close the issue.
Comment #3
ppblaauw commentedWould be nice if it was that simple, although there are many ways a pager can be designed.
Different width of slideshow pager.
Pager items with not only images, but also text.
Different flexible width of pager items.
To complex at the moment to add this to the module.
For changing the layout of the pager, the CSS has to be changed.
When someone has a patch to add this feature, just reopen the issue.
Comment #4
SweeneyTodd commentedI have done an example of how this could be done based on the vsd-upright-60p template (files are attached with comments to show where I have modified them). I have modified the views_slideshow_ddblock.module file so it passes the number of pager display items across to the theme files. The theme.tpl file adds this as part of a class and the theme.css file has a number of new classes (1 for each value of the number of pager display items) - I only did up to 5 as an example. I also changed some of the pager and navi block layout in the css to auto centre the blocks.
I have not done any cross-browser testing on this so I don't know how this will look in IE6/7/8 and it will also need a check in the theme.tpl file to make sure there are enough pager items to fill all the pager display slots - if not then use number of pager items instead.
You are right this is only a solution for a single theme and each theme will have to be modified separately for this to work, but it is a mechanism that could be used to get a degree of flexibility without the user having to change the css every time they change the number of pager items.
Comment #5
ppblaauw commentedThank you for the modifications, how you could have a flexible amount of pager items set in the configuration page of the slideshow. It's a good start to get this implemented in themes.
Will have a more in depth look at it how to match this with the flexible slidehow width settings.
I think the changes need to be made in the CSS files for each predefined slideshow width.
Will also need to add some documentation how to make the calculations for custom slideshow width style sheets.
A user will not change the amount of pager items often. This is only a more easy way for the user to set the amount of pager-items with a configuration setting instead of changing CSS.
Of course there is a trade of in complexity/amount in CSS to support flexibility with settings and changing the CSS itself. (documentation what to change would be helpful in this)
Comment #6
adam_c commentedHi, Ive copied accross your files, I went to the views admin page, set the number of pages to 3 but then when I click update it just hangs. The little throbber just goes round and round forever.
What do you think could be causing this?
This is a much needed feature so I hope it can be fixed.
Thanks
Comment #7
SweeneyTodd commentedDo you have a link so I can see what the problem is?
Comment #8
adam_c commentedAfter uninstalling then reinstalling the module it now works. Computers... strange things