Great module - I got it working in 10 minutes with my own View. I spent all yesterday working on version 6.x-1 and still did not resolve the php "foreach" errors.

I had no field mapped to slide_title but had the node Body mapped to Slide_text. When there was no content in the Body, an empty text box was displayed on the screen over the bottom of the slide. I was using the vsd-upright-60p template in case that is important.

CommentFileSizeAuthor
#8 vsd-bbblock-Text-block-is-showing-on-slide-when-no-text-is-present-803144.patch2.99 KBSweeneyTodd
#4 views slideshow ddblock mods 2.zip1.5 KBSweeneyTodd

Comments

ppblaauw’s picture

ppblaauw commented
Status: Active » Postponed (maintainer needs more info)

Maybe you have a wysiwyg editor enabled and it places <p></p> in the slide_title or slide_body field, which is the reason the slidetext box shows up.

When there is no slidetext or the slidetext checkbox is not checked in the configuration page, the box should not show up.

Hope this helps you further, please let me know.

SweeneyTodd’s picture

SweeneyTodd commented
Status: Postponed (maintainer needs more info) » Active

I have set up a test:

Case 1) Nothing mapped to slide-title and Body mapped to slide-text. The "Use Slide Text" box is ticked. I do not use a wysiwig editor - I use the native Drupal forms to build nodes. I have checked the page source and there is nothing in the slide-text div (see typical below):

   <div class="slider clear-block border">
    <div class="slider-inner clear-block border">
                  <div class="slide clear-block border">
        <div class="slide-inner clear-block border">
         <img  class="imagefield imagefield-field_image" width="105" height="75" alt="" src="http://www.sourcebottle.com/sites/default/files/kateandkarinasmall.jpg?1274026609" />                   <div class="slide-text slide-text-horizontal slide-text-bottom clear-block border">

           <div class="slide-text-inner clear-block border">
                                               </div> <!-- slide-text-inner-->
          </div>  <!-- slide-text-->
           
        </div> <!-- slide-inner-->
       </div>  <!-- slide-->

The grey slide text box still appears on top of the slide image. I have tested this in Zen and Garland and it appears in both themes.

Case 2) Nothing mapped to slide-title and nothing mapped to slide-text. The "Use Slide Text" box is ticked. This is probably not a normal situation but it should display ok.

The css produced and the display are the same - I still have the grey slide text box appearing on top of the slide image.

I will leave the ddb block like this for a few days in case you want to have a look (http://www.sourcebottle.com/).
This is a test site I am using at the moment so there are other views-based image display blocks on the front page I am also testing so it looks a mess.

ppblaauw’s picture

ppblaauw commented

When you don't want slidetext, you need to unset the slidetext checkbox in the configuration page.

Hope this helps you further, please let me know.

SweeneyTodd’s picture

SweeneyTodd commented
StatusFileSize
new views slideshow ddblock mods 2.zip1.5 KB

I have modified the views-slideshow-ddblock-cycle-block-content-vsd-upright-60p.tpl file to fix this problem. I have added a comment so you can see which line I have changed.

Now you can mix slide without text along with those with text and not have an empty text box shown on the slide.

This will have to be fixed for each of the themes that uses slide text.

ppblaauw’s picture

ppblaauw commented
Category: bug » feature

Thanks for the solution not to show the slidetext block when the slide_title and slide_text variables don't have a value, so a mix of slides with and without a slide-text block can be used .

The problem is when the slide_title and the slide_text variables have no content also the read more button is not shown.

Will spend more time on this later, to find a good solution to implement.

Make this a feature request.

SweeneyTodd’s picture

SweeneyTodd commented

Another way to achive this (and be able to see the Read More link) would be to change the div class if it was empty rather than removing it. It could then be given no background instead of opaque grey. You would then not see the text container but could display the Read More link.

ppblaauw’s picture

ppblaauw commented
Status: Active » Postponed (maintainer needs more info)

#6, Do you have code for post #6

SweeneyTodd’s picture

SweeneyTodd commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new vsd-bbblock-Text-block-is-showing-on-slide-when-no-text-is-present-803144.patch2.99 KB

Sorry for the delay, I though I had created this patch and submitted it a while ago.

This patch is for the vsd-upright-60p theme only. Anyone who is interested should be able to patch other themes in a similar way or ask for help on specific cases.

If there is no text (title or slide text) then the grey/opaque text background is not shown.
The div container is still there (but with a different class - 'slide-text-read-more-only') so the Read More can still be shown and the background for this can be themed separately if required.

mandreato’s picture

mandreato commented

Hi,
I've tried a simple view slideshow DDB setting just an image field as slide image target; the slide text container is shown (a dark gray band on the bottom).
After un-checking the "Use slide text" option, the band is still there.

ppblaauw’s picture

ppblaauw commented

#8 for now you can delete the transparent image of the slide-text in CSS

hope this helps you further, please let me know.