Hi:
After upgrading to 2.1 my slideshow stopped displaying the pager. After I saved it a few times the pager came back. BUT, the pager does not show which slide it is on any more. It used to be the number was underlined in the pager when it was on the slide the number corresponded to. Now there is no underlining and you can no longer tell which slide is showing.

Comments

ikeizer’s picture

ikeizer commented

Issue confirmed. It seems the module now adds the active class not to the link, but to the span which causes the break of the pager.

redndahead’s picture

redndahead commented

Is the break the fact that there is no underline? If that's the case then the easy fix is to adjust your css.

ikeizer’s picture

ikeizer commented

Yes, it is a matter of a CSS fix, but this should be done in the release ofcourse.

redndahead’s picture

redndahead commented

It was changed on purpose up a level. The reason for that is it makes it easier to do extra theming.

intyms’s picture

intyms commented
Status: Active » Fixed

The reason for that is it makes it easier to do extra theming

I agree. Marking as fixed.

@entrepreneur27
See this issue. It may help you #825450: How to use images as pagination?
If it won't help you, place a link to your webpage here.

entrepreneur27’s picture

entrepreneur27 commented

So, if I understand this correctly, the latest module upgrade has made my working site no longer work unless I go in and make some additional changes to some css file somewhere. Am I understanding this correctly?

Personally, I would prefer it if module "improvements" did not break my site. However, given that this seems to be the agreed on approach, I would like some help, please. When you talk about changing the css file, I am not sure which css file you mean. There are several on my site which I have avoided touching until now. And where in the css file does this code need to go? And what are the implications of this in future upgrades of various other modules and of core? Do I need to modify the css file in each case?

intyms’s picture

intyms commented

@#6 entrepreneur27
hi
English is not my native language, so it is very hard for me to explain some things. Maybe somebody else will help you to explain the things related to module and core upgrades.

let me know please your webpage address. and i will tell you which CSS file to change.

added later
if you have some time try to study these pages:
http://drupal.org/theme-guide
http://www.cssbasics.com/

also get firefox and firebug.
search in google to find more about firebug.

redndahead’s picture

redndahead commented
Status: Fixed » Active

@enterpreneur27 What did you upgrade from? Version 1.0 to version 2.1? version 2.0 to version 2.1?

redndahead’s picture

redndahead commented
Status: Active » Postponed (maintainer needs more info)

Please set this back to active after you reply.

redndahead’s picture

redndahead commented
Status: Postponed (maintainer needs more info) » Fixed

Marking as fixed

entrepreneur27’s picture

entrepreneur27 commented
Status: Fixed » Active

I was previously using 6.x-2.0-beta2. I tried to upgrade to the recommended 2.1 version. I have reverted to the 2.0beta2 because of this issue.
The webpage in question is www[dot]accelerationcoop[dot]com

Any help would be great.

redndahead’s picture

redndahead commented

@entrepreneur27. somewhere in your css you have

.views_slideshow_singleframe_pager.numbered a.activeSlide {
  text-decoration: underline;
}

change it to this when you upgrade.

.views_slideshow_singleframe_pager.numbered .activeSlide a {
  text-decoration: underline;
}
redpuma’s picture

redpuma commented

This got me on that upgrade too. Now an upgrade to 2.3 has "broken" my site as far as my client is concerned. The pager has moved way out of position.

Guess I'll have to include a re-theme quote for every time this module is updated or leave it at 2.1 for ever. Sigh......

redndahead’s picture

redndahead commented
Status: Active » Fixed

@redpuma
There is no 2.3 version

Between 2.1 and 2.2 or 2.x-dev for that matter nothing has changed with the pager formatting. So nothing in views slideshow should have broken your pager.

You are welcome to look through the release notes of every release, http://drupal.org/node/160350/release , and see what's changed.

The change to the activeSlide class was done in version 2.1 with the upgrade of jquery cycle. If you would like to still upgrade to the latest version, but not have the activeSlide change then download jQuery cycle 2.82 or earlier and overwrite the file in the views_slideshow/js/ directory.

redpuma’s picture

redpuma commented

2.3 ... Ah yes 2.2 was a long day.

I see so it is likely an upgraded jQuery Cycle caused the formatting problem, just checked and 6.x-2.1 is using version 2.81 vs version 2.86 in 6.x-2.2.

Good to know I can update the module but keep with the older version of jQuery Cycle. Thanks for the tip.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.