There are missing Drupul Dependency in code. Please check.

CommentFileSizeAuthor
#2 views_slideshow_drupal_dependency-2895853-2.patch1.3 KBjayesh_makwana
views_slideshow.txt1.49 KBjayesh_makwana

Comments

jayesh_makwana created an issue. See original summary.

jayesh_makwana’s picture

jayesh_makwana commented
StatusFileSize
new views_slideshow_drupal_dependency-2895853-2.patch1.3 KB

We created a patch for Drupal Dependency for this module. Please check and apply it.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Assigned: jayesh_makwana » Unassigned
Status: Active » Needs work

Thanks for the patch!
Unfortunately, it isn't quite right; although the views dependency should be listed as drupal:views, the the other dependencies shouldn't - they should have specify their own parent project not drupal. I'll fix that and commit.

  • NickWilde committed ee6387c on 8.x-4.x 
    Issue #2895853 by jayesh_makwana, NickWilde: Please use Drupal...
nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.