Having a different number of results for the first slide of slideshow is a handy feature - see MSN homepage for an example.

CommentFileSizeAuthor
#9 different_number_of-2665150-9.patch8.8 KBvbouchet
#2 different_number_of-2665150-2.patch8.83 KBnickdickinsonwilde

Comments

NickWilde created an issue. See original summary.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Title: Different number of rows on first slide » Different number of rows on first slide [patch attached]
Status: Active » Needs review
StatusFileSize
new different_number_of-2665150-2.patch8.83 KB

Status: Needs review » Needs work

The last submitted patch, 2: different_number_of-2665150-2.patch, failed testing.

The last submitted patch, 2: different_number_of-2665150-2.patch, failed testing.

The last submitted patch, 2: different_number_of-2665150-2.patch, failed testing.

The last submitted patch, 2: different_number_of-2665150-2.patch, failed testing.

The last submitted patch, 2: different_number_of-2665150-2.patch, failed testing.

The last submitted patch, 2: different_number_of-2665150-2.patch, failed testing.

vbouchet’s picture

vbouchet
Location Toulouse
commented
Status: Needs work » Needs review
StatusFileSize
new different_number_of-2665150-9.patch8.8 KB

Hi NickWilde,

Please find an updated patch. I only fixed minor typo (unexisting variable name, too many spaces) and updated (or rollbacked) your array implementation. I know the D8 style should be $var = []; as you did, but there entire project currently use the old-fashion implementation. So I would prefer to avoid mixing syntax and will create a dedicated ticket to update code syntax.

I tested the patch and it works well, it only requires some theming but it is specific to each project ;-)

Let me know if it's ok for you and will merge it. Thanks,

Status: Needs review » Needs work

The last submitted patch, 9: different_number_of-2665150-9.patch, failed testing.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented

Yeah - I much prefer the [] syntax but I can definitely see the arguments for doing it as a single issue rather than piecemeal. (to be clear, I'm totally good with it)

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Assigned: nickdickinsonwilde » Unassigned
Status: Needs work » Fixed

Back to [] syntax since everything else is. Fair bit of reworking on this actually.

  • NickWilde committed 630daec on 8.x-4.x 
    Issue #2665150 by NickWilde, vbouchet: Different number of rows on first...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.