Closed (fixed)
Project:
Views (for Drupal 7)
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
24 Jun 2013 at 01:19 UTC
Updated:
19 Mar 2022 at 20:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
infojunkiePatch attached.
Comment #1.0
infojunkieBetter wording
Comment #2
chris matthews commentedThe 6 year old patch to views_handler_field_date.inc does not apply to the latest views 7.x-3.x-dev and if still applicable needs reroll.
Comment #3
andrew answer commentedPatch rerolled.
Comment #4
renatog commentedYeah, it really makes sense. Tested and with patch #3 this text will appear to be translatable. Thank you so much for your contribution people
Comment #5
mustanggb commentedSeems like a bit of a hack, wouldn't it be better to usedrupal_alter().Nevermind, seems like D8 might do it using translate, so fair enough.
Comment #6
mustanggb commentedRestoring status.
Comment #7
damienmckennaShould the other uses of $custom_format or $second_custom_format also be wrapped in t()?
On an aside, the logic in views_handler_field_date::render() is rather peculiar, I think I'll set up a different issue for that.
Comment #9
damienmckennaCommitted. Thanks everyone.