Looking at the code paths to get to VersioncontrolGitRepository::exec(), I am not comfortable with the escaping removed by commit 90baa24. It can be reverted, I have an alternative fix for VersioncontrolGitRepositoryHistorySynchronizerDefault::processTags().

CommentFileSizeAuthor
#5 2169079.diff1.93 KBdrumm
#1 2169079.diff2.04 KBdrumm

Comments

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Active » Needs review
StatusFileSize
new 2169079.diff2.04 KB

Patch is attached.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

It looks like the test request was sent several days ago and still hasn't run? Is something up?

marvil07’s picture

marvil07 commented

Yes, the associated branch seems to be broken, so I will need to take a look at that first. Notice that using the patch as alternative, i.e. reverting the other change is also valid, but testbot cannot do that, so it should be tested manually.
Hopefully I can go back to this this week.

drumm’s picture

drumm
he/him
Location NY, US
commented

I included the revert in this patch, which is the first two hunks.

drumm’s picture

drumm
he/him
Location NY, US
commented
StatusFileSize
new 2169079.diff1.93 KB

Attached is a more-simple patch which does not cause regressions. There are still the same test failures as the branch at https://drupal.org/node/214407/qa, which I believe are unrelated.

drumm’s picture

drumm
he/him
Location NY, US
commented

I filed an issue for the failing tests: #2181077: Invalid cache on restoring cache controller settings

The last submitted patch, 1: 2169079.diff, failed testing.

marvil07’s picture

marvil07 commented
Status: Needs review » Fixed

Thanks for the fix, added to 7.x-1.x.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Fixed » Reviewed & tested by the community

I don't see the commit, maybe it needs to be pushed?

marvil07’s picture

marvil07 commented
Status: Reviewed & tested by the community » Fixed

@drumm, yes, actually I pushed the tag, so the commits where there and the last release included the commits, but I did not update the 7.x-1.x branch. Thanks for noticing, it's now there ;-)

drumm’s picture

drumm
he/him
Location NY, US
commented

Deployed to Drupal.org

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit 6e7a588 on 7.x-1.x, fix-invalid-default-branches, fullsync-memory authored by drumm, committed by marvil07: 
    Issue #2169079 by drumm: Fix escaping for tags on default reposync...