While I was migrating API from 1.x to 2.x I tried to preserve rules integration, but I still need to make sure every case is working, so I make this issue to avoid forget that.

BTW: Good time to receive feedback about what other places rules should be interacting with VCS API.

Comments

sdboyer’s picture

sdboyer commented
Issue tags: +git phase 2

Our rules integration is now quite completely broken. We're going to need to revisit it from the ground up.

I've removed includes/versioncontrol.rules.inc entirely. If/when we get around to rebuilding this, we can pull what was there from history. Note that the file also had token integration in there.

We might want to retag this git phase 3, it might not be necessary for phase 2 work.

marvil07’s picture

marvil07 commented
Title: Review rules integration » Re-add rules integration when API is stable
marvil07’s picture

marvil07 commented
Status: Active » Closed (duplicate)

Mmm.. duplicating this old issue in favour of #1020220: Reintroduce token integration, that has patches in!

  • Commit 71de3ba on repository-families, drush-vc-sync-unlock by sdboyer: 
    Remove rules integration, as it's now quite completely broken....

  • Commit 71de3ba on repository-families by sdboyer: 
    Remove rules integration, as it's now quite completely broken....

  • sdboyer committed 71de3ba on d8port 
    Remove rules integration, as it's now quite completely broken....