drupal-check docroot/modules/contrib/varbase_editor

drupal-check docroot/modules/contrib/varbase_editor
 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------------------------- 
  Line   varbase_editor.install                                               
 ------ --------------------------------------------------------------------- 
  43     Call to deprecated function file_scan_directory():                   
         in drupal:8.8.0 and is removed from drupal:9.0.0.                    
         Use \Drupal\Core\File\FileSystemInterface::scanDirectory() instead.  
 ------ --------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 1 error


Upgrade status


CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Varbase Editor 8.x-7.x-dev
Scanned on Thu, 02/13/2020 - 15:59.

1 warning found.

#3112185: Drupal 9 Readiness for [Varbase Editor] with Drupal coding standard
and practice

modules/contrib/varbase_editor/varbase_editor.info.yml:
┌──────────┬──────┬─────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                         MESSAGE                         │
├──────────┼──────┼─────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to  │
│ manually │      │ varbase_editor.info.yml to designate that the module is │
│          │      │ compatible with Drupal 9. See                           │
│          │      │ https://www.drupal.org/node/3070687.                    │
│          │      │                                                         │
└──────────┴──────┴─────────────────────────────────────────────────────────┘


Drupal coding standard and Drupal Practice check should pass

PHPCS, PHPCBF for both --standard=Drupal and --standard=DrupalPractice

Check Varbase Editor Drupal coding standard

phpcbf --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_editor/
phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_editor/

Check Varbase Editor Drupal Practice

phpcbf --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_editor/

phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_editor/


Comments

angela_G created an issue. See original summary.

angela_g’s picture

angela_g’s picture

Status: Active » Needs review
rajab natshah’s picture

Title: Drupal 9 Deprecated Code Report » Drupal 9 Readiness for [Varbase Editor] with Drupal coding standard and practice
Issue summary: View changes

Angela, Thanks for reporting and patching

rajab natshah’s picture

rajab natshah’s picture

Issue summary: View changes

  • RajabNatshah committed 1c3270f on 8.x-7.x authored by angela_G
    Issue #3112185 by angela_G: Drupal 9 Readiness for [Varbase Editor] with...
rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem
Issue summary: View changes
Issue tags: +varbase-8.8.4, +varbase-8.9.0, +varbase-9.0.0
StatusFileSize
new14.63 KB

Committed ... Thank you again, Angela

rajab@vardot-dev:/var/www/html/products/varbase_editor$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md /var/www/html/products/varbase_editor/


rajab@vardot-dev:/var/www/html/products/varbase_editor$ phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md /var/www/html/products/varbase_editor/


rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue tags: -varbase-9.0.0 +varbase-9.1.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

rajab natshah’s picture

Title: Drupal 9 Readiness for [Varbase Editor] with Drupal coding standard and practice » Drupal 9 compatibility for [Varbase Editor] with Drupal coding standard and practice