Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When you have multiple point TID's features for a single product, going back to edit one will always show you the last point feature you've added for that product. This is because the database record is loaded by nid rather than pfid. See the attached patch for a proposed fix.
Also, it seems like both the upid and nid columns aren't needed in the uc_userpoints_products table.
Comment | File | Size | Author |
---|---|---|---|
#2 | multiple_tid_per_product.patch | 6.11 KB | rbayliss |
multiple_tid_per_product.patch | 1.26 KB | rbayliss |
Comments
Comment #1
bmagistro CreditAttribution: bmagistro commentedI do not consider this a bug. It was not designed for that purpose at the time. Changing to feature request.
Comment #2
rbayliss CreditAttribution: rbayliss commentedFair enough. What feels buggy about it is that you can add multiple points features to a product, but then they don't work. Regardless, it's a few lines of code away from having this feature. This last patch also changes the point decrementing on order complete to allow for multiple TID's. Please note that I also changed a couple of strings so they made more sense (to me).
Comment #3
YK85 CreditAttribution: YK85 commentedsubscribing
Comment #4
that0n3guy CreditAttribution: that0n3guy commentedsubscribe...
Comment #5
eme CreditAttribution: eme commentedWorks fine for me. Would be good to include it in dev. Thx.
Comment #6
bmagistro CreditAttribution: bmagistro commentedI am looking at moving the current beta to stable and then integrating this. Can you guys confirm that it has been "stable" and some of the major bugs (such as the double discounting) are not exhibited anymore? Once that moves there I plan to start addressing these feature requests.
Comment #7
thePanz CreditAttribution: thePanz commentedThis patch do not takes into account the product quantity during userpoints save process!
Cheers
Comment #8
thePanz CreditAttribution: thePanz commentedMoved the issue to "Product" component