The Upgrade Status module reports all "Unsafe usage of new static()" errors generated by PHPStan. These are almost certainly false positives; the usage of "new static()" is an established pattern in Drupal code.
Furthermore, there is no feasible alternative to ignoring: using final on the class or the constructor prevents inheritance, and using new self() may break other interfaces which expect static (see discussion in core issue).
The errors are ignored in the module's phpstan.neon, but that file is not used when running the analysis.
The errors are NOT ignored in the module's deprecation_testing_template.neon, which is used when running the analysis. This causes them to be reported as compatibility issues.
Run upgrade_status:analyze on any codebase which has custom modules which override __construct() and create()
Copy the ignore rule from phpstan.neon to deprecation_testing_template.neon:
# new static() is a best practice in Drupal, so we cannot fix that.
- "#^Unsafe usage of new static#"
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #4
miha.wagner commentedI've gotten this too since upgrading. MR fixes the issue as suggested by author. Fixed the issue in our project. Thank you marttir.
Comment #6
solideogloria commentedComment #7
solideogloria commented