Thanks for an awesome module! I'm actually not using it in Drupal (though we're major users of Drupal), but instead pulled the code out and am using it plus a PHP Freshbooks API implementation to write a connection between the two.

The key call I'm using is getTimeInvested and getProjectTimeInvested so I've added this and rolled it into a patch.

Let me know if it needs changing - I think I've followed the standards for the most part.

CommentFileSizeAuthor
#2 829880_time_invested.patch1.7 KBlangworthy
#1 unfuddle_api.classes.inc-829880.patch2.02 KBsokrplare

Comments

sokrplare’s picture

sokrplare commented
StatusFileSize
new unfuddle_api.classes.inc-829880.patch2.02 KB

Now attaching the patch with the issue number (nid?) in the file name.

langworthy’s picture

langworthy commented
StatusFileSize
new 829880_time_invested.patch1.7 KB

rerolled to cleanup whitespace/tabs

langworthy’s picture

langworthy commented

Our team doesn't use unfuddle for time tracking so I can't test this too well.

My only comments are wondering if we can use the $filters array as an argument rather than the current three arguments used?

sokrplare’s picture

sokrplare commented

Sorry, somehow thought I was subscribed and would get notified if there was a comment. Thanks for the reroll!

Good thought on the $filters array. Makes sense to me and would make things a bit more easily extensible if they add additional arguments later on.

If you want, I can setup a test account for you in my company's Unfuddle instance. Just let me know!

acouch’s picture

acouch commented
Status: Needs review » Fixed

I've committed this.

sokrplare’s picture

sokrplare commented

Great!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.