Problem/Motivation
From Rajab.
Some module are altering field formatters with hook_field_formatter_third_party_settings_form and hook_preprocess_field
Examples:
Proposed resolution
Are we compatible with them?
Issue fork ui_patterns-3487548
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
pdureau commentedComment #4
oldebComment #5
pdureau commentedComment #6
pdureau commentedMoved to RC1
Comment #7
oldebBoth mentionned modules seems to work as intended.
The only thing I noted is that when using a field formatter to render the field inside a component's slot, the "Remove field markup" option is not there but that don't seems like a bug to me.
Comment #8
pdureau commentedThanks Olivier.
So, when using a field formatter to render the field inside a component's slot,
field_formatter_rangeworks but nonomarkup? If yes, we can close the issue.So, when using a field formatter to render the field inside a component's slot,
field_formatter_rangedoesn't work? If yes, we have to investigateComment #9
pdureau commentedComment #10
oldebI confirm that when displaying a formatter inside a component slot, neither of
field_formatter_rangeornomarkupis working.We should definitively investigate more.
Comment #11
pdureau commentedSo, we don't trigger
hook_field_formatter_third_party_settings_formin our Field Formatter Source plugin for slots. We need to trigger it.Careful, there is maybe another hook to check at render time (
field_formatter_range_preprocess_field?).Olivier's job is done here. Who is taking the subject?
Comment #12
smovs commentedComment #13
smovs commentedComment #14
just_like_good_vibesComment #16
just_like_good_vibesi updated the code, would you test again?
Comment #17
pdureau commentedIt works when I'm at the first level, when my formatter is the consumer plugin:
✅ I see only the 2nd, the 3rd and the 4th items.
But it doesn't work at deeper levels when the formatter is itself a slot source plugin.
Comment #18
pdureau commentedA follow up issue will be created for the remaining fix.