Problem/Motivation
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork ui_patterns-3443441
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
pdureau commentedDon't forget to update specs
Comment #3
pdureau commentedComment #4
smustgrave commentedNot sure I follow is this to move over https://www.drupal.org/project/ui_patterns_blocks ?
Comment #5
pdureau commentedThe news UI Patterns Blocks submodule is taking the name of https://www.drupal.org/project/ui_patterns_blocks and is covering the features of 4 contrib modules:
Some of those modules expose one block by component (UI Patterns Pattern Block, Component Blocks), some a single block for all components (UI Patterns Entity Links). We started the work in Alpha1 by doing a single block for all components, but we changed our mind and we now want a block by component.
Comment #6
smustgrave commentedSo first time seeing these modules. But if I understand we want component block merged in?
Comment #7
pdureau commentedExcept
component_blocks, they are crap modules. I am the author of one, and Christian is the author of an other, so I allow myself to be harsh 🤣However, each of them has an interesting feature we want to include into UI Patterns 2
Covering the scope of component_blocks was not the initial plan, and we are not in contact with Lee and the other component_blocks contributors.
However, thanks to our new Source plugin type and the other blocks modules we are merging, we have realized than we already have everything we need to also cover component_blocks scope without properly merging it. So I am now mentioning it.
Comment #8
smustgrave commentedI speak to @larowlan has he helps me out with core stuff. So if we want to look int component_block I can start with that if I can free up.
Comment #9
pdureau commentedThe issue which may be considered as covering component_blocks scope is #3444768: [2.0.0-alpha3] Blocks: Add sources with an entity context
The current issue is much simpler: instead of having a single block with a component selector in
blockForm(): https://git.drupalcode.org/project/ui_patterns/-/blob/2.0.x/modules/ui_p...We need to generate a block by component, without a component selector in the
blockForm()I guess
initial_component_idparameter ComponentFormBuilderTrait::buildComponentsForm() is the one to load or not the component selector.Comment #10
oldebComment #12
oldebComment #14
pdureau commented